Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack build improvements #29

Merged
merged 3 commits into from
Nov 2, 2018
Merged

Webpack build improvements #29

merged 3 commits into from
Nov 2, 2018

Conversation

manuelbieh
Copy link
Owner

Description / What does this PR do?

Related Issue / Story / Ticket

manuelbieh
manuelbieh commented Nov 2, 2018
View reviewed changes
scripts/build.js Outdated
@@ -28,18 +28,20 @@ const generateStaticHTML = async () => {
const pageContent = await page.content();
fs.writeFileSync(`${paths.clientBuild}/index.html`, pageContent);
await browser.close();
process.exit();
// process.exit();
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment

@manuelbieh manuelbieh merged commit 657b4e1 into master Nov 2, 2018
@manuelbieh manuelbieh deleted the webpack-build-improvements branch November 2, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manuelbieh