This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Create PropertyIconDeterminationActivity.kt #1392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translated PropertyIconDeterminationActivity.java into Kotlin
added import R. Other than that, LGTM!
ZiZasaurus
approved these changes
Jan 21, 2021
tobrun
reviewed
Jan 28, 2021
| import com.mapbox.mapboxsdk.style.sources.GeoJsonSource | ||
|
|
||
|
|
||
| class PropertyIconDeterminationActivity : AppCompatActivity(), MapboxMap.OnMapClickListener { |
There was a problem hiding this comment.
add class level documentation that explains what this example is doing
Comment on lines
+28
to
+32
| private val SOURCE_ID = "SOURCE_ID" | ||
| private val RED_ICON_ID = "RED_ICON_ID" | ||
| private val YELLOW_ICON_ID = "YELLOW_ICON_ID" | ||
| private val LAYER_ID = "LAYER_ID" | ||
| private val ICON_PROPERTY = "ICON_PROPERTY" |
There was a problem hiding this comment.
constants should be put into the companion object
| private val YELLOW_ICON_ID = "YELLOW_ICON_ID" | ||
| private val LAYER_ID = "LAYER_ID" | ||
| private val ICON_PROPERTY = "ICON_PROPERTY" | ||
| private var mapView: MapView? = null |
There was a problem hiding this comment.
You don';t need to rely on nullable views and using findViewById is you use android-kotlin-extensions: https://antonioleiva.com/kotlin-android-extensions/
There was a problem hiding this comment.
kotlinx.android.synthetic is no longer a recommended practice. It is deprecated.
- https://android-developers.googleblog.com/2020/11/the-future-of-kotlin-android-extensions.html
- https://proandroiddev.com/migrating-the-deprecated-kotlin-android-extensions-compiler-plugin-to-viewbinding-d234c691dec7
Do you have a plan to use it in Mapbox?
|
|
||
| override fun onResume() { | ||
| super.onResume() | ||
| mapView!!.onResume() |
There was a problem hiding this comment.
avoid using !! (with updating remark above, this won't be needed anymore)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translated PropertyIconDeterminationActivity.java into Kotlin