Exit mbtiles read stream if we hit a tile maximum #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapsam
changed the title
|
This is ready to go! Added a test that uses a known fixture of four tiles with four unique property values and only asks for a sample of those tiles, asserting that the number of unique property values is equal to the number of tiles requested. Would appreciate a review from anyone if they have time! |
GretaCB
approved these changes
Jul 19, 2017
| @@ -408,3 +408,23 @@ test('MBTiles with two layers', t => { | |||
| t.end(); | |||
| }).catch(t.threw); | |||
| }); | |||
|
|
|||
| test('MBTiles limits max tiles', t => { | |||
There was a problem hiding this comment.
👏 Wow, great test and fixture.
| readStream.on('data', function() { | ||
| if (count >= options.maxTiles) { | ||
| readStream.unpipe(analysisStream); | ||
| readStream.end(); |
There was a problem hiding this comment.
Nice. Properly closing streams is typically a big 👀 ❓ for me , but this looks super clear and👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw a wrench at the mbtiles readstream if we hit a reasonable tile count.
refs: #30
cc @rclark @GretaCB