Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQLite 3.24.0 optimized for binary size #645

Merged
merged 4 commits into from
Aug 9, 2018

Conversation

jfirebaugh
Copy link
Contributor

@jfirebaugh jfirebaugh commented Aug 9, 2018

Using both -Os and -flto (which we've found to substantially reduce binary size).

Testing over in mapbox/mapbox-gl-native#12596.

This could serve as an example for mapbox/cpp#22

@jfirebaugh
Copy link
Contributor Author

jfirebaugh commented Aug 9, 2018

😢 https://circleci.com/gh/mapbox/mapbox-gl-native/141024

../../../mason_packages/linux-x86_64/sqlite/3.24.0-min-size/lib/libsqlite3.a: error adding symbols: Archive has no index; run ranlib to add one

Seems we are running afoul of this item from mapbox/cpp#22:

  • llvm-ar and llvm-ranlib on path (and set in environment AR=/path/to/llvm-ar RANLIB=/path/to/llvm-ranlib)

@jfirebaugh jfirebaugh merged commit 5a3698c into master Aug 9, 2018
@jfirebaugh jfirebaugh deleted the sqlite-3.24.0-min-size branch August 9, 2018 21:52
@jfirebaugh
Copy link
Contributor Author

Gave up on LTO. It probably doesn't make too much of a difference anyway, given that SQLite compiles as a single large .c file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant