-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto upgrade legacy filters #30
base: master
Are you sure you want to change the base?
Conversation
This PR is now rebased against latest master and includes the latest mapbox-gl-style-spec release, which means its ready for further review and testing /cc @ian29 @ericfischer @mapsam |
This PR came up today in conversation with @briandaviddavidson. The main holdup on moving this forward is that we need to build confidence around
Getting the answers to these questions would involve:
|
This leverages functionality inside the mapbox-gl-style-spec to auto-upgrade legacy filter syntax.
This avoids errors in styles which mix the legacy syntax with the modern syntax.
Will fail until the style-spec version is upgraded, which can happen after mapbox/mapbox-gl-js#8493 is in a release.