Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any interest in EditorSettings? #126

Closed
wants to merge 1 commit into from

Conversation

singalen
Copy link
Contributor

@singalen singalen commented Jan 8, 2022

I honestly see no real point, but maybe you want it for functional completeness. If not, I'll close this PR.

I needed to read the chunk size, but I don't think EditorSettings is an authoritative source.

@bjorn
Copy link
Member

bjorn commented Jan 10, 2022

I needed to read the chunk size, but I don't think EditorSettings is an authoritative source.

Yeah, at the moment it is, but it's not very nice to rely on this. Personally I think rs-tiled should use a chunk size that is independent of the stored files. See also #125 (review).

@bjorn
Copy link
Member

bjorn commented Jan 10, 2022

I guess alternatively, if we recognize the idea of dynamic chunk sizes is just a bad idea, then the implication is that storing the size on each chunk was unnecessary, and we could introduce attributes outside of the editorsettings that store the size and get rid of the width and height attributes on each chunk element. I think we should then also store the chunk coordinates in chunks rather than tiles. The main problem with this, of course, is the breaking of compatibility.

@bjorn
Copy link
Member

bjorn commented Feb 23, 2022

Stored chunk sizes are no longer relevant now that #157 was merged. Editor settings might be relevant in the future, but likely only once we would start work on #171, so closing this for now.

@bjorn bjorn closed this Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants