Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge current into next #222

Merged
merged 7 commits into from
May 2, 2022
Merged

Merge current into next #222

merged 7 commits into from
May 2, 2022

Conversation

aleokdev
Copy link
Contributor

@aleokdev aleokdev commented May 2, 2022

No description provided.

aleokdev and others added 6 commits April 18, 2022 11:50
* Add basic chunk utils to infinite layers

* Mark TODOs

* Apply suggestions from code review

Co-authored-by: Thorbjørn Lindeijer <[email protected]>

* Apply interface suggestions from code review

* Update changelog

Co-authored-by: Thorbjørn Lindeijer <[email protected]>
@aleokdev aleokdev requested a review from bjorn May 2, 2022 10:48
@aleokdev aleokdev merged commit 896bcb9 into mapeditor:next May 2, 2022
@bjorn
Copy link
Member

bjorn commented May 10, 2022

Whoops, a branch merge like this should not have been committed as squashed. :-(

I was quite confused why GitHub was still indicating next was "7 commits behind current".

@aleokdev
Copy link
Contributor Author

Any way to fix it now?

@bjorn
Copy link
Member

bjorn commented May 10, 2022

Any way to fix it now?

We can either "rewrite history", by reverting the next branch to before that change and then properly merging in current, and repeating the changes done afterwards, or we can leave the mistake be and just follow it up with a proper merge (to make the next branch appear up-to-date with the changes in current).

Personally, I think rewriting history might be preferable, because if we don't do that the history will just look confusing.

@bjorn
Copy link
Member

bjorn commented May 19, 2022

@aleokdev Alright, the next branch now contains a proper merge roughly at the same time you did it, and then I've re-applied the commits for #170 and #161. Now, we can try merging current into next again for change 672b5ca. It has some conflicts in object.rs.

If you have local branches that were based on the previous next, you'll need to rebase them before opening a pull request.

@bjorn
Copy link
Member

bjorn commented May 19, 2022

@aleokdev Sorry, I forgot about the LayerType::TileLayer rename, so I've adjusted the merge again and re-applied the other changes again. Should be all good this time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants