Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace libflate with flate2 #281

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

quininer
Copy link
Contributor

@quininer quininer commented Dec 27, 2023

Initially rs-tiled used flate2 but switched to libflate because flate2 didn't support wasm #47 , but flate2 has been supporting wasm via miniz_oxide for a while now rust-lang/flate2-rs#161.

This reduces dependency duplicated by other crates and has performance benefits.

bjorn
bjorn previously approved these changes Dec 27, 2023
Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@aleokdev
Copy link
Contributor

Could you please update CHANGELOG.md as well?

@quininer
Copy link
Contributor Author

I updated the changelog and version.

Copy link
Contributor

@aleokdev aleokdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@aleokdev aleokdev merged commit c8ac751 into mapeditor:current Dec 27, 2023
@quininer quininer deleted the switch-back-flate2 branch December 27, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants