Support for class properties #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'll look at this on PC whenever I have time |
bjorn
reviewed
Feb 20, 2024
- Open and save the test map so we know for certain it's in line with Tiled output - If we can't find a property type on a class property, default to an empty string instead of "class"
bjorn
previously approved these changes
Feb 21, 2024
|
Only thing missing are the changes in the CHANGELOG.md file, after that it's good to go! Thanks! |
bjorn
previously approved these changes
Feb 21, 2024
|
I forgot this is a breaking change (adds new variant to PropertyValue), so it should be based against |
|
@Deukhoofd I've tried to change the base branch of the PR, but it's a bit tricky, since you've created it directly from your Or we could just use this PR to update the |
|
Couldn't these changes be rebased on next? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the new class properties introduced in Tiled 1.8, as described here.
I had to write some slightly hacky code to work around the fact that its child tag is optional, which would break the parser when it tried to parse it anyway.
The new property value ClassValue differs from the other PropertyValues in that its a struct enum variant, instead of a tuple one. I did this due to the additional property type that is included in it. Having it as a struct variant feels cleaner to me than having it as a two element tuple.