Enable checks in main and test, and fix tests

Makefile

@@ -20,8 +20,9 @@ checks: build-builder
 	docker run --rm --user=$(shell id -u):$(shell id -g) \
 		--volume=$(PWD)/core/src/:/src/core/src/:ro \
 		--volume=$(PWD)/reports/:/src/core/build/reports/ \
+		--volume=$(PWD)/core/build/resources/:/src/core/build/resources/ \
 		mapfish_print_builder \
-		gradle --parallel :core:spotbugsMain :core:checkstyleMain
+		gradle --parallel spotbugsMain checkstyleMain spotbugsTest checkstyleTest
 
 .PHONY: tests
 tests: build-builder

core/src/test/java/org/mapfish/print/config/package-info.java

@@ -0,0 +1,2 @@
+/** The parent package for processors. */
+package org.mapfish.print.config;

core/src/test/java/org/mapfish/print/map/geotools/FeaturesParserTest.java

@@ -107,7 +107,7 @@ public MockClientHttpRequest handleRequest(URI uri, HttpMethod httpMethod) {
                     + "AUTHORITY[\"EPSG\",\"4326\"]]";
             MockClientHttpRequest mockClientHttpRequest = new MockClientHttpRequest();
             mockClientHttpRequest.setResponse(
-                new MockClientHttpResponse(wkt.getBytes(), HttpStatus.OK));
+                new MockClientHttpResponse(wkt.getBytes(Constants.DEFAULT_CHARSET), HttpStatus.OK));
             return mockClientHttpRequest;
           }
         });
@@ -143,7 +143,7 @@ public MockClientHttpRequest handleRequest(URI uri, HttpMethod httpMethod) {
                     + "0],UNIT[\"Degree\",0.017453292519943295]]";
             MockClientHttpRequest mockClientHttpRequest = new MockClientHttpRequest();
             mockClientHttpRequest.setResponse(
-                new MockClientHttpResponse(wkt.getBytes(), HttpStatus.OK));
+                new MockClientHttpResponse(wkt.getBytes(Constants.DEFAULT_CHARSET), HttpStatus.OK));
             return mockClientHttpRequest;
           }
         });

core/src/test/java/org/mapfish/print/output/JasperReportSvgOutputFormatTest.java

@@ -9,6 +9,7 @@
 import java.util.HashMap;
 import java.util.Map;
 import org.junit.Test;
+import org.mapfish.print.Constants;
 import org.mapfish.print.config.Configuration;
 import org.mapfish.print.config.ConfigurationFactory;
 import org.mapfish.print.wrapper.json.PJsonObject;
@@ -41,11 +42,11 @@ public void testPrint() throws Exception {
                 .replaceFirst("test", "actual")
                 .replace("expectedReport.svg", "actualReport.svg"));
     actual.getParentFile().mkdirs();
-    BufferedWriter writer = new BufferedWriter(new FileWriter(actual));
-    writer.write(outputStream.toString());
+    BufferedWriter writer = new BufferedWriter(new FileWriter(actual, Constants.DEFAULT_CHARSET));
+    writer.write(outputStream.toString(Constants.DEFAULT_CHARSET));
     writer.close();
 
     String expected = getFileContent(BASE_DIR + "expectedReport.svg");
-    assertEquals(actual.toString(), expected, outputStream.toString());
+    assertEquals(actual.toString(), expected, outputStream.toString(Constants.DEFAULT_CHARSET));
   }
 }

core/src/test/java/org/mapfish/print/processor/ProcessorDependencyGraphTest.java

@@ -81,7 +81,7 @@ public void testCreateTaskAllDependenciesAreMissing() {
 
     final ProcessorDependencyGraph graph = new ProcessorDependencyGraph();
     //noinspection ConstantConditions
-    graph.addRoot(new ProcessorGraphNode(processor, null));
+    graph.addRoot(new ProcessorGraphNode(processor, new MetricRegistry()));
     graph.createTask(values);
   }
 

examples/src/test/java/org/mapfish/print/AbstractApiTest.java

@@ -42,7 +42,8 @@ protected String getPrintSpec(String file) throws IOException {
   protected void setPrintSpec(String printSpec, ClientHttpRequest request) throws IOException {
     request.getHeaders().setContentType(MediaType.APPLICATION_FORM_URLENCODED);
 
-    OutputStreamWriter writer = new OutputStreamWriter(request.getBody());
+    OutputStreamWriter writer =
+        new OutputStreamWriter(request.getBody(), Constants.DEFAULT_ENCODING);
     writer.write(URLEncoder.encode(printSpec, Constants.DEFAULT_ENCODING));
     writer.flush();
   }