Fix non-vectorized LineString decoding #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mactrem
force-pushed
the
bugfix/non_vectorized_linestring
branch
2 times, most recently
from
53665d3 to
058e898
Compare
mactrem
force-pushed
the
bugfix/non_vectorized_linestring
branch
from
058e898 to
3f1c11b
Compare
This was referenced Jun 15, 2024
3 tasks
springmeyer
added a commit
to springmeyer/maplibre-tile-spec
that referenced
this pull request
Jun 16, 2024
springmeyer
added a commit
to springmeyer/maplibre-tile-spec
that referenced
this pull request
Jun 20, 2024
springmeyer
added a commit
that referenced
this pull request
Jun 21, 2024
Currently we support both a "Non-vectorized (aka sequential)" decoding path and a "Vectorized" decoding path. In the future we can and should consolidate to just one (vectorized), but for the moment we need to keep two because the JS decoder is targeting the non-vectorized path. With that in mind we need to ensure we are testing the non-vectorized java decoder. So, this PR makes improvements to the decoder tests to: - Test both decoding paths as much as possible - The non-vectorized path has more issues, so temporary accommodations are made to allow tests to pass by asserting on expected errors (this gets the code running at least until we can fix its behavior) - It is not going to be obvious in the diff, but this also starts testing some tiles which used to fail in the vectorized path, but no longer do (after #158 was fixed) - Finally, by asserting on the number of expected errors returned for known failures, this starts allowing the tests to iterate through more features during the comparison which ensures the tests are not hiding additional errors behind other asserts which fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136