Added fastapi_server and settings file; renamed user-token #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkantsev
reviewed
May 14, 2020
|
|
||
| app = FastAPI() | ||
|
|
||
| player_token_name: Dict[str, str] = {} |
There was a problem hiding this comment.
👋how would you describe the purpose of each of the player variables? I couldn't tell just by their names.
There was a problem hiding this comment.
It seems to be all possible mappings between token and player name or number. For a start player_token_name is not really used. @luchesar, you mind if we clean up a bit?
vkantsev
approved these changes
May 14, 2020
vkantsev
reviewed
May 14, 2020
vkantsev
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.