Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jobs.Runner #38

Merged
merged 5 commits into from
May 3, 2024
Merged

Add jobs.Runner #38

merged 5 commits into from
May 3, 2024

Conversation

markuswustenberg
Copy link
Member

@markuswustenberg markuswustenberg commented Apr 22, 2024

This adds a new package jobs which provides an abstraction to run background jobs, backed by the queue.

@markuswustenberg markuswustenberg marked this pull request as draft April 22, 2024 12:20
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 83.07692% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 90.17%. Comparing base (9abc8f8) to head (b907807).

Files Patch % Lines
jobs/runner.go 82.53% 17 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   89.83%   90.17%   +0.34%     
==========================================
  Files           2        3       +1     
  Lines         236      336     +100     
==========================================
+ Hits          212      303      +91     
- Misses         17       25       +8     
- Partials        7        8       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Runnable example
- Docs
-

Remove:
- Logger from Queue

Also did some refactoring.
@markuswustenberg markuswustenberg marked this pull request as ready for review May 3, 2024 08:51
@markuswustenberg markuswustenberg changed the title Add job runner Add jobs.Runner May 3, 2024
@markuswustenberg markuswustenberg merged commit 78755b2 into main May 3, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant