Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

[WIP] RESP support #56

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[WIP] RESP support #56

wants to merge 7 commits into from

Conversation

hugoabonizio
Copy link
Collaborator

@hugoabonizio hugoabonizio commented May 12, 2017

Checklist to RESP (REdis Serialization Protocol) support.

  • Split requests into Plain and RESP requests to parse separatelly
  • Add RESP specifc tests
  • Fix pending lists related tests
  • Error handling
  • Add documentation
  • Benchmark comparing to Redis performance

@marceloboeira
Copy link
Owner

@hugoabonizio you don't have to support the current "implementation" of the response. If we decide to use RESP then we get rid of everything else. Don't worry about that.

@hugoabonizio
Copy link
Collaborator Author

@marceloboeira Alright, I'll replace the current protocol in this branch.

@marceloboeira
Copy link
Owner

@hugoabonizio any updates on this one? I was thinking about using redis-benchmark¹ to figure it out how fast are we 😄.

[1] - https://redis.io/topics/benchmarks

@hugoabonizio
Copy link
Collaborator Author

Hi @marceloboeira!
I managed to run redis-cli connecting to BoJack and running the commands seamlessly, but I got stuck in testing. The test suite sometimes get stuck and I didn't find the reason yet.
I want to return to this issue soon, I'm not too far of making redis benchmark run (at least for GET/SET commands that are the same in both Redis and BoJack). 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants