Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): fix package exports, default must be last #140

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix(deps): fix package exports, default must be last #140

merged 1 commit into from
Dec 2, 2023

Conversation

rdy
Copy link
Contributor

@rdy rdy commented Dec 2, 2023

When using dotenv-mono under webpack (target: node), it throws an error when the package is loaded because "default" isn't the last entry in package.json.

According to the documentation in node, the order of this actually matters, so this PR is to avoid the error from webpack. This is also detailed in webpack documentation.

@marcocesarato marcocesarato merged commit 7cec78c into marcocesarato:master Dec 2, 2023
5 checks passed
@marcocesarato
Copy link
Owner

Thanks for your pull request! I've merged it in and released the change. Appreciate your contribution to fixing that webpack issue with dotenv-mono. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants