Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a filter option to search for parts of entries contained in lists #921

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

Signynt
Copy link
Contributor

@Signynt Signynt commented Jul 11, 2024

When filtering projects, sometimes I want to be able to match parts of entries of lists.
For example if files in a project have list properties containing california adventure, hotel california and californiacation, then under filter, I can select the option "contains part of" in the drop down, and enter in califorina. This will match any files which contain any of the above property entries.

I'm uncertain as to how this filter option should be named, and am open to suggestions that might be more descriptive of what the filter option does.

image

@Acylation
Copy link
Collaborator

Will be a QOL feature! Thanks for proposing and contributing. I suggest expressions like "has keyword" or "matches keyword" on this case. And the input component should use a text input rather than tags/multitext input.

@Signynt
Copy link
Contributor Author

Signynt commented Jul 12, 2024

@Acylation Thanks.
I've changed the wording to "has keyword".

Currently it seems to be implemented so that each property type only allows one input component type, and I'm not sure how I would elegantly change that. If it's something simple I'm missing I'd be happy if you could add it!
Since it's only an aesthetic difference, I wouldn't mind too much if it stays the way it currently is.

@Signynt
Copy link
Contributor Author

Signynt commented Jul 12, 2024

I saw the build failed, so I've updated the code to fix the issue.

@Acylation
Copy link
Collaborator

Acylation commented Jul 16, 2024

Yes I'll take care of refactoring to allow multiple input types with each field type. This is also a must to support dynamic date filters described in #918 and #835.

@Acylation Acylation added the area/filtering Issues related to filters, color conditions and sorting. label Jul 17, 2024
@Acylation Acylation added this to the 1.17.4 milestone Jul 17, 2024
@Acylation Acylation added the kind/enhancement Issues related to improving existing features label Jul 17, 2024
@Acylation
Copy link
Collaborator

Since the right part is now string rather than array, I've also change the matching functions accordingly. Please don't hesitate to reach out / contribute back if there are any problems.

@Acylation Acylation merged commit 7aca0b6 into marcusolsson:main Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/filtering Issues related to filters, color conditions and sorting. kind/enhancement Issues related to improving existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants