Merge pull request Expensify#23562 from namhihi237/fix-19651-remove-f…

…irst-request-from-queue

remove first request

src/libs/actions/PersistedRequests.js

@@ -25,8 +25,18 @@ function save(requestsToPersist) {
  * @param {Object} requestToRemove
  */
 function remove(requestToRemove) {
-    persistedRequests = _.reject(persistedRequests, (persistedRequest) => _.isEqual(persistedRequest, requestToRemove));
-    Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, persistedRequests);
+    /**
+     * We only remove the first matching request because the order of requests matters.
+     * If we were to remove all matching requests, we can end up with a final state that is different than what the user intended.
+     */
+    const requests = [...persistedRequests];
+    const index = _.findIndex(requests, (persistedRequest) => _.isEqual(persistedRequest, requestToRemove));
+    if (index !== -1) {
+        requests.splice(index, 1);
+    }
+
+    persistedRequests = requests;
+    Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests);
 }
 
 /**