Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Performance: chat input #12

Merged
merged 101 commits into from
Aug 25, 2023
Merged

[WIP] Performance: chat input #12

merged 101 commits into from
Aug 25, 2023

Commits on Aug 4, 2023

  1. Merge branch 'migrate-composer-fc-web' of github.com:margelo/expensif… 

    …y-app-fork into perf/composer-investigations
    @hannojg
    hannojg committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    17d4889 View commit details
    Browse the repository at this point in the history

  2. Merge branch '@stas-kravchuk/16263-migrate-reportactioncompose-to-fun… 

    …ction' of github.com:margelo/expensify-app-fork into perf/composer-investigations
    @hannojg
    hannojg committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    91b7d91 View commit details
    Browse the repository at this point in the history

  3. move reportactioncompose to own folder

    @hannojg
    hannojg committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    9f1cac2 View commit details
    Browse the repository at this point in the history

  4. first refactor

    @hannojg
    hannojg committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    12405c3 View commit details
    Browse the repository at this point in the history

  5. temp: hack good performance

    @hannojg
    hannojg committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    0cab4a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Merge branch '@stas-kravchuk/16263-migrate-reportactioncompose-to-fun… 

    …ction' of github.com:margelo/expensify-app-fork into perf/composer-investigations
    @hannojg
    hannojg committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    9a8201b View commit details
    Browse the repository at this point in the history

  2. fix issues after

    @hannojg
    hannojg committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    ea26c2c View commit details
    Browse the repository at this point in the history

  3. enabled suggestions

    @hannojg
    hannojg committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b002f08 View commit details
    Browse the repository at this point in the history

  4. add value prop back

    @hannojg
    hannojg committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    5042b4b View commit details
    Browse the repository at this point in the history

  5. use insertedEmojis ref correctly

    @hannojg
    hannojg committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    1bf0177 View commit details
    Browse the repository at this point in the history

  6. add selection change back

    @hannojg
    hannojg committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3ab1ca4 View commit details
    Browse the repository at this point in the history

  7. fix issue with menu closing instantly

    @hannojg
    hannojg committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    9ec7169 View commit details
    Browse the repository at this point in the history

  8. pass callbacks

    @hannojg
    hannojg committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    cfc7b25 View commit details
    Browse the repository at this point in the history

  9. call bloc calculations

    @hannojg
    hannojg committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    e7d3a95 View commit details
    Browse the repository at this point in the history

  10. wip

    @hannojg
    hannojg committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    1156d61 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Merge branch 'migrate-composer-fc-web' of github.com:margelo/expensif… 

    …y-app-fork into refactor-report-action-compose
    @hannojg
    hannojg committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    eb2892c View commit details
    Browse the repository at this point in the history

  2. Merge branch '@stas-kravchuk/16263-migrate-reportactioncompose-to-fun… 

    …ction' into refactor-report-action-compose
    @hannojg
    hannojg committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    a7a489a View commit details
    Browse the repository at this point in the history

  3. fix split implementations of suggestions

    @hannojg
    hannojg committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    e247161 View commit details
    Browse the repository at this point in the history

  4. wip: split out SendButton & AttachmentPickerWithMenu

    @hannojg
    hannojg committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    9739c08 View commit details
    Browse the repository at this point in the history

  5. wip: simplify code

    @hannojg
    hannojg committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    eb9baf8 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Revert "wip: simplify code" 

    This reverts commit eb9baf8.
    @hannojg
    hannojg committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    6673ba4 View commit details
    Browse the repository at this point in the history

  2. Revert "wip: split out SendButton & AttachmentPickerWithMenu" 

    This reverts commit 9739c08.
    @hannojg
    hannojg committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    730f4c9 View commit details
    Browse the repository at this point in the history

  3. Split out SendButton component

    @hannojg
    hannojg committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    b846cbe View commit details
    Browse the repository at this point in the history

  4. wip: splitting out AttachmentPicker

    @hannojg
    hannojg committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    33b8e4b View commit details
    Browse the repository at this point in the history

  5. wip: splitting out AttachmentPicker

    @hannojg
    hannojg committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    45a8842 View commit details
    Browse the repository at this point in the history

  6. wip: split out SendButton & AttachmentPickerWithMenu 

    move actionButtonRef
    @hannojg
    hannojg committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    ba38175 View commit details
    Browse the repository at this point in the history

  7. wip: move menu items calc to separate component

    @hannojg
    hannojg committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    433d616 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Merge branch 'main' of github.com:margelo/expensify-app-fork into ref… 

    …actor-report-action-compose
    @hannojg
    hannojg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3e957a3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'migrate-composer-fc-web' of github.com:margelo/expensif… 

    …y-app-fork into refactor-report-action-compose
    @hannojg
    hannojg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    74bd410 View commit details
    Browse the repository at this point in the history

  3. Merge branch '@stas-kravchuk/16263-migrate-reportactioncompose-to-fun… 

    …ction' of github.com:margelo/expensify-app-fork into refactor-report-action-compose
    @hannojg
    hannojg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    ff18a4f View commit details
    Browse the repository at this point in the history

  4. wip: move composer to its own component

    @hannojg
    hannojg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    575046d View commit details
    Browse the repository at this point in the history

  5. remove unused prop

    @hannojg
    hannojg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    cdefcc6 View commit details
    Browse the repository at this point in the history

  6. wip: move composer to its own component 

    move maxComposerLines
    @hannojg
    hannojg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    e820194 View commit details
    Browse the repository at this point in the history

  7. wip: Split out composer 

    First working and performing solution
    @hannojg
    hannojg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    dca3df8 View commit details
    Browse the repository at this point in the history

  8. Add UpdateComment component

    @hannojg
    hannojg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7f73769 View commit details
    Browse the repository at this point in the history

  9. don't make triggerHotkeyActions depend on value

    @hannojg
    hannojg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    1a5454f View commit details
    Browse the repository at this point in the history

  10. Suggestions remove unused props

    @hannojg
    hannojg committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0bfc0b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. add suggestions back

    @hannojg
    hannojg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3d4403e View commit details
    Browse the repository at this point in the history

  2. moved over updating frequently used emojis

    @hannojg
    hannojg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ad4b571 View commit details
    Browse the repository at this point in the history

  3. fix show popover menu

    @hannojg
    hannojg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3ee30c9 View commit details
    Browse the repository at this point in the history

  4. enable ExceededCommentLength again

    @hannojg
    hannojg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    557c8d0 View commit details
    Browse the repository at this point in the history

  5. forward reportActions

    @hannojg
    hannojg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3f591e2 View commit details
    Browse the repository at this point in the history

  6. cleanup forward ref code according to common pattern

    @hannojg
    hannojg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    52fc6e8 View commit details
    Browse the repository at this point in the history

  7. clean

    @hannojg
    hannojg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    040688c View commit details
    Browse the repository at this point in the history

  8. Merge branch '@stas-kravchuk/16263-migrate-reportactioncompose-to-fun… 

    …ction' of github.com:margelo/expensify-app-fork into refactor-report-action-compose
    @hannojg
    hannojg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ef17bab View commit details
    Browse the repository at this point in the history

  9. Apply fixes from origin PR

    @hannojg
    hannojg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    7edceee View commit details
    Browse the repository at this point in the history

  10. fix update component updating too often

    @hannojg
    hannojg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    0b5f770 View commit details
    Browse the repository at this point in the history

  11. fix crash

    @hannojg
    hannojg committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5b9336d View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Merge branch 'main' into refactor-report-action-compose

    @hannojg
    hannojg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    b175eae View commit details
    Browse the repository at this point in the history

  2. Merge branch '@stas-kravchuk/16263-migrate-reportactioncompose-to-fun… 

    …ction' into refactor-report-action-compose
    @hannojg
    hannojg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    46a252a View commit details
    Browse the repository at this point in the history

  3. reapply Expensify@8554863

    @hannojg
    hannojg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    5b61e12 View commit details
    Browse the repository at this point in the history

  4. reapply Expensify@e209754

    @hannojg
    hannojg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    af6d104 View commit details
    Browse the repository at this point in the history

  5. reapply Expensify@2671883

    @hannojg
    hannojg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    45947dd View commit details
    Browse the repository at this point in the history

  6. reapply Expensify@479f317

    @hannojg
    hannojg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    eaa3440 View commit details
    Browse the repository at this point in the history

  7. reapply Expensify@cd6d115

    @hannojg
    hannojg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    1641dc0 View commit details
    Browse the repository at this point in the history

  8. reapply Expensify@a96be82

    @hannojg
    hannojg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d76106b View commit details
    Browse the repository at this point in the history

  9. reapply Expensify@dc4ceea

    @hannojg
    hannojg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f174b04 View commit details
    Browse the repository at this point in the history

  10. reapply Expensify@a6c309e

    @hannojg
    hannojg committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    066f980 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Merge branch 'main' of github.com:margelo/expensify-app-fork into ref… 

    …actor-report-action-compose
    @hannojg
    hannojg committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8b2c37f View commit details
    Browse the repository at this point in the history

  2. reapply Expensify@6319e59

    @hannojg
    hannojg committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    baa5e8b View commit details
    Browse the repository at this point in the history

  3. fix isFullComposerAvailable

    @hannojg
    hannojg committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    893b7e2 View commit details
    Browse the repository at this point in the history

  4. fix initial isFocused state

    @hannojg
    hannojg committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    6870d17 View commit details
    Browse the repository at this point in the history

  5. Use tryGetCachedValue for draft comment

    @hannojg
    hannojg committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    f1398ce View commit details
    Browse the repository at this point in the history

  6. remove todo

    @hannojg
    hannojg committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    ea6f00b View commit details
    Browse the repository at this point in the history

  7. remove unneeded code

    @hannojg
    hannojg committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    905c9b5 View commit details
    Browse the repository at this point in the history

  8. move personalDetails to onyx

    @hannojg
    hannojg committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    10c55b3 View commit details
    Browse the repository at this point in the history

  9. fix mention suggestion picker size

    @hannojg
    hannojg committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    f4b9079 View commit details
    Browse the repository at this point in the history

  10. fix crash opening attachment picker

    @hannojg
    hannojg committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    448d358 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. move to existing pattern

    @hannojg
    hannojg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    4968fb1 View commit details
    Browse the repository at this point in the history

  2. migrate also the modal state to established pattern

    @hannojg
    hannojg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a3ea498 View commit details
    Browse the repository at this point in the history

  3. remove debug log

    @hannojg
    hannojg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7081e15 View commit details
    Browse the repository at this point in the history

  4. fix suggestion height position

    @hannojg
    hannojg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    91d210c View commit details
    Browse the repository at this point in the history

  5. fix suggestions not showing on clicking again into composer

    @hannojg
    hannojg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8596920 View commit details
    Browse the repository at this point in the history

  6. use hooks instead of HOCs

    @hannojg
    hannojg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9d05dab View commit details
    Browse the repository at this point in the history

  7. remove debug code

    @hannojg
    hannojg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0b987fa View commit details
    Browse the repository at this point in the history

  8. rename ReportComposerWithSuggestions -> ComposerWithSuggestions

    @hannojg
    hannojg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8e8d5c4 View commit details
    Browse the repository at this point in the history

  9. prop types

    @hannojg
    hannojg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    6a7b82e View commit details
    Browse the repository at this point in the history

  10. fix tests

    @hannojg
    hannojg committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    c02fdac View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Merge branch 'main' of github.com:Expensify/App into refactor-report-… 

    …action-compose
    @hannojg
    hannojg committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    72e2bbf View commit details
    Browse the repository at this point in the history

  2. apply changes to ReportActionCompose

    @hannojg
    hannojg committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    cf5d835 View commit details
    Browse the repository at this point in the history

  3. perf: don't update lines when we don't have to

    @hannojg
    hannojg committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    ebd8e74 View commit details
    Browse the repository at this point in the history

  4. change name

    @hannojg
    hannojg committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    28426ce View commit details
    Browse the repository at this point in the history

  5. fix prop type issues

    @hannojg
    hannojg committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    95a0193 View commit details
    Browse the repository at this point in the history

  6. fix lint

    @hannojg
    hannojg committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3e3c6ed View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Update src/pages/home/report/ReportActionCompose/suggestionProps.js 

    Co-authored-by: Vit Horacek <[email protected]>
    @hannojg @mountiny
    hannojg and mountiny authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    cf6cf7a View commit details
    Browse the repository at this point in the history

  2. Update src/pages/home/report/ReportActionCompose/SendButton.js 

    Co-authored-by: Vit Horacek <[email protected]>
    @hannojg @mountiny
    hannojg and mountiny authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6ab1ccf View commit details
    Browse the repository at this point in the history

  3. removed todos

    @hannojg
    hannojg committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    0dd4773 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:Expensify/App into refactor-report-… 

    …action-compose
    @hannojg
    hannojg committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    b4936ec View commit details
    Browse the repository at this point in the history

  5. fix issues after merge

    @hannojg
    hannojg committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f2f397e View commit details
    Browse the repository at this point in the history

  6. add blur function

    @hannojg
    hannojg committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c3792d6 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into refactor-report-action-compose

    @hannojg
    hannojg committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    9826f49 View commit details
    Browse the repository at this point in the history

  8. foc focus state

    @hannojg
    hannojg committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    9b7c07b View commit details
    Browse the repository at this point in the history

  9. fix IOU options not showing up

    @hannojg
    hannojg committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    893137a View commit details
    Browse the repository at this point in the history

  10. fix crash

    @hannojg
    hannojg committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    faf1e15 View commit details
    Browse the repository at this point in the history

  11. remove unused import

    @hannojg
    hannojg committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ad30918 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Merge branch 'main' of github.com:Expensify/App into refactor-report-… 

    …action-compose
    @hannojg
    hannojg committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    bd22c57 View commit details
    Browse the repository at this point in the history

  2. reapply changes

    @hannojg
    hannojg committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5e93ecf View commit details
    Browse the repository at this point in the history

  3. fix lint + pass measure callback

    @hannojg
    hannojg committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    1e97af0 View commit details
    Browse the repository at this point in the history

  4. move prop types to separate file

    @hannojg
    hannojg committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    0ccd7ae View commit details
    Browse the repository at this point in the history

  5. move libs/ComposerUtils/debouncedSaveReportComment

    @hannojg
    hannojg committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    89b569d View commit details
    Browse the repository at this point in the history

  6. fix marking reports as draft when opening

    @hannojg
    hannojg committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    e64a5d9 View commit details
    Browse the repository at this point in the history