feat: Make every hybrid std::shared_ptr<T>
nullable
#18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes every
std::shared_ptr<T>
nullable by default. We now have to treat every std::shared_ptr as nullable in our codebase.We still need to think about if this change makes sense.
Before:
After:
Note
This was also possible before by simply using
std::optional<std::shared_ptr<T>>
, so this PR simply changes that shared ptrs are nullable by default.