Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android release mode assets #263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

p-sebastian
Copy link
Collaborator

@p-sebastian p-sebastian commented Aug 28, 2024

Android release mode bundles glb assets into the raw folder if they are bundled with the require syntax, instead of linking them with something like react-native-assets. This avoids having to bundle the assets twice if you are using them via require, which works correctly on iOS.

Otherwise the asset cannot be found by android. And this is a problem only in release mode Android.

Copy link
Member

@hannojg hannojg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, I just need to test this once. Will do that later today!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants