-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Add keyboard shortcuts for navigating between sidebar panels #3477
Open
metaboulie
wants to merge
5
commits into
marimo-team:main
Choose a base branch
from
metaboulie:eugene/panel-navigation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Ctrl-Shift-{ and Ctrl-Shift-} shortcuts to navigate between panels in the sidebar. The navigation only works when the sidebar is open and cycles through visible panels in order. - Add panel.nextPanel and panel.previousPanel hotkey definitions - Add nextPanel and previousPanel actions to chrome state management - Register hotkey handlers in AppChrome component
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@metaboulie is attempting to deploy a commit to the marimo Team on Vercel. A member of the Team first needs to authorize it. |
for more information, see https://pre-commit.ci
|
Make panel.nextPanel and panel.previousPanel hotkeys configurable by setting them to NOT_SET by default. This allows users to set their preferred key bindings through the hotkeys menu or marimo.toml rather than having hardcoded defaults.
…ie/marimo into eugene/panel-navigation
mscolnick
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Add keyboard shortcuts to navigate between panels in the sidebar, making it easier for users to switch between different views without using the mouse. The shortcuts are Ctrl-Shift-{ and Ctrl-Shift-}.
Bildschirmaufnahme.2025-01-17.um.20.16.36.mov
🔍 Description of Changes
hotkeys.ts
:panel.nextPanel
: Navigate to next panel (Ctrl/Cmd-Shift-})panel.previousPanel
: Navigate to previous panel (Ctrl/Cmd-Shift-{)chrome/state.ts
to handle panel navigation:nextPanel
: Cycles to the next visible panelpreviousPanel
: Cycles to the previous visible panelapp-chrome.tsx
usinguseHotkey
hook📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick