improvement: better sql completions #3930
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Light2Dark
force-pushed
the
fix-sql-completions
branch
from
313452e to
cf917ac
Compare
|
|
||
| export const ItemSubtext: React.FC<{ content: string }> = ({ content }) => { | ||
| return ( | ||
| <span className="text-xs text-black bg-gray-200 rounded px-1"> |
There was a problem hiding this comment.
bg-gray-200 won't support dark mode, and i think it could be slightly lighter
maybe bg-[var(--slate-8] text-[var(--slate-9]?
| @@ -361,6 +378,8 @@ const SchemaItem: React.FC<{ | |||
| <span className={cn(isSelected && isExpanded && "font-semibold")}> | |||
| {schema.name} | |||
| </span> | |||
| {/* Do we want this? They could change the default by executing USE schema.. */} | |||
| {isDefaultSchema && <ItemSubtext content="default" />} | |||
There was a problem hiding this comment.
maybe we can remove for now? we can look if other SQL apps do this:
e.g. jetbrains or dbbeaver, if you can drum up screenshots (but don't need to spend too much time)
| tables[table.name] = columns; | ||
|
|
||
| if (isDefaultDb) { | ||
| const schemaMap = (mapping[schema.name] ?? {}) as Record< |
There was a problem hiding this comment.
you can put the typecheck on the LHS const schemaMap: Record<string, string[]>;. this might be safer than casting
| database_name: Optional[str] = None | ||
| dialect_queries = { | ||
| "postgresql": "SELECT current_database()", | ||
| "mssql": "SELECT DB_NAME()", |
There was a problem hiding this comment.
i guess sql alchemy or the inspect class doesn't have native support for this?
There was a problem hiding this comment.
yeah, that's true, the inspector is schema oriented. Supporting multi-database inspection is a little bit tricky, even though you can execute queries from another db
| cacheConfig = { | ||
| dialect: guessDialect(connection), | ||
| schema: combinedSchema, | ||
| schema: mapping, | ||
| defaultSchema: connection.default_schema ?? undefined, |
There was a problem hiding this comment.
can you verify that the table from the default schema does get bubbled up? im not sure if this include the db.schema, but that might be required
There was a problem hiding this comment.
yeap it does! Will attach a screenshot/vid
📝 Summary
Follow up from #3898 , add the shortest and correct completions to AI & sql completions panel.
Adds default schema & db introspection + update API.
🔍 Description of Changes
schema_name.table_name, for diff databases, usedb_name.schema_name.table_nameMaybe:
📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick