Add support in Commons CSV for tracking byte positions during parsing #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarrenJAN
commented
Nov 18, 2024
DarrenJAN
commented
- Add augment the builder and add a private constructor to create CVSParser class
- Adjust format
- Use a try-with-resources block
- improve the comments
- Use a Charset instead of a string Charset name in ExtendedBufferedReader class
yunzvanessa
requested changes
Nov 19, 2024
| // "org/apache/commons/csv/CSV-196/japanese.csv"), format, 0L, 1L, "UTF-8"); | ||
| CSVParser parser = format.parse(getTestInput( | ||
| "org/apache/commons/csv/CSV-196/japanese.csv"), 0L, 1L, "UTF-8"); | ||
| .setDelimiter(',') |
| .setQuote('\'') | ||
| .get(); | ||
| CSVParser parser = new CSVParser.Builder() | ||
| .setFormat(format) |
src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java
Outdated
Show resolved
Hide resolved
yunzvanessa
reviewed
Nov 19, 2024
| @@ -510,7 +521,7 @@ public CSVParser(final Reader reader, final CSVFormat format, final long charact | |||
| this(reader, format, characterOffset, recordNumber, null); | |||
| } | |||
|
|
|||
| /** | |||
| /** | |||
There was a problem hiding this comment.
Sorry just noticed an extra indentation problem
yunzvanessa
requested changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.