Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comments #15

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix comments #15

merged 2 commits into from
Dec 13, 2024

Conversation

DarrenJAN
Copy link

  1. Don't initialize to the default value enableByteTracking
  2. Javadoc should start with "Gets".
  3. Using final

yunzvanessa
yunzvanessa approved these changes Dec 13, 2024
View reviewed changes
src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java Outdated
* and byte tracking option. Initializes an encoder if byte tracking is enabled
* and a character set is provided.
*
* @param reader the reader to wrap. Must not be {@code null}.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "the reader to wrap" mean?

@DarrenJAN DarrenJAN merged commit 8387f79 into marklogic:CSV-196-master Dec 13, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunzvanessa yunzvanessa yunzvanessa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarrenJAN @yunzvanessa