Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(translator): check for shadowing data with a tag destructure #2257

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LuLaValva
Copy link
Member

Description

  • Added test for shadowing with a destructure
  • The shadowing issue mentioned in the issue is not replicated by Marko's test suite
  • With minimal testing, it seems this is not replicable. I will look further to attempt replication.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@LuLaValva LuLaValva self-assigned this Jul 9, 2024
Copy link

changeset-bot bot commented Jul 9, 2024

⚠️ No Changeset found

Latest commit: fe7b997

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (5567690) to head (fe7b997).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2257   +/-   ##
=======================================
  Coverage   87.49%   87.49%           
=======================================
  Files         333      333           
  Lines       33885    33885           
  Branches     1860     1860           
=======================================
  Hits        29648    29648           
  Misses       4226     4226           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected rename destructed property data to input
1 participant