Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: for loop by attribute support property string + fixes #2259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mlrawlings
Copy link
Member

Description

  • feat: support string for by attribute: <for|x| of=y by="id">
  • fix: support function by for non of loops on server

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Jul 19, 2024

⚠️ No Changeset found

Latest commit: d37190f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 41.52542% with 69 lines in your changes missing coverage. Please review.

Project coverage is 87.36%. Comparing base (40d4067) to head (d37190f).

Files Patch % Lines
packages/translator-tags/src/core/for.ts 36.27% 64 Missing and 1 partial ⚠️
packages/runtime-tags/src/dom/control-flow.ts 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2259      +/-   ##
==========================================
- Coverage   87.51%   87.36%   -0.16%     
==========================================
  Files         333      333              
  Lines       34061    34168     +107     
  Branches     1894     1912      +18     
==========================================
+ Hits        29808    29850      +42     
- Misses       4240     4305      +65     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey
Copy link
Contributor

TODO: this feature is already added but we should copy the test from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants