Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAGS API] chore: avoid dynamic tag logic in if runtime #2510

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Feb 8, 2025

⚠️ No Changeset found

Latest commit: 9366417

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DylanPiercey DylanPiercey changed the title chore: avoid dynamic tag logic in if runtime [TAGS API] chore: avoid dynamic tag logic in if runtime Feb 8, 2025
@DylanPiercey DylanPiercey force-pushed the avoid-dynamic-tag-code-in-if branch from 27e90ed to 9366417 Compare February 8, 2025 02:48
@DylanPiercey DylanPiercey merged commit 454624e into main Feb 8, 2025
8 checks passed
@DylanPiercey DylanPiercey deleted the avoid-dynamic-tag-code-in-if branch February 8, 2025 02:51
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.33%. Comparing base (bd59c96) to head (9366417).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/runtime-tags/src/dom/renderer.ts 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2510   +/-   ##
=======================================
  Coverage   87.33%   87.33%           
=======================================
  Files         352      352           
  Lines       40492    40510   +18     
  Branches     2687     2686    -1     
=======================================
+ Hits        35363    35381   +18     
+ Misses       5108     5107    -1     
- Partials       21       22    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant