Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datatables cs2: rewrite player equipment tracking #478

Merged

Conversation

micvbang
Copy link
Contributor

NOTE: this is not 100% accurate yet, but it's a big step in the right direction.

Thanks to esbengc for describing the required logic!

@markus-wa
Copy link
Owner

I investigated a bit more, and I think we first need to fix the variable array length decoding - which is also what #450 kind of mentions, that this affects all variable length data.

The main issue is that fieldState.state needs to be cut to the length returned by the baseDecoder of the field every time an item is removed.

Without that I'm not sure we can trust anything 😅

NOTE: this is not 100% accurate yet, but it's a big step in the right
direction.

Thanks to esbengc for describing the required logic!
@micvbang micvbang force-pushed the micvbang/simplify-weapon-inventory branch from 0d8941b to 4d7029c Compare November 20, 2023 19:21
@markus-wa markus-wa merged commit 33abbfb into markus-wa:master Nov 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants