Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: excessive CPU use in the MIDI SenderThread #24

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Sep 6, 2019

  1. fix excessive CPU use in the MIDI SenderThread

    I ran a profiler to determine where the runaway CPU usage appeared, and it
    showed up as dominated by calls to msleep() in SenderThread.  I did the
    standard replacement of the busy loop with a mutex and wait condition, which
    solved the problem.  Initial interactive testing showed no degradation of
    timing accuracy in playback.
    daslomin-microsoft committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    0d1a91d View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2019

  1. load metronome click audio file from resource

    This means that the program doesn't need to look for the file in a particular
    local path since it's embedded in the executable (it was already there anyway).
    QMediaPlayer doesn't reliably support loading from resources but QSoundEffect
    does, and the Qt docs recommend using the latter for this kind of purpose
    anyway.
    Div Slomin committed Sep 7, 2019
    Configuration menu
    Copy the full SHA
    97add7c View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. mac crashed on QSoundEffect unless you set the audio output device ex…

    …plicitly; also tightened timing of the metronome by removing silence from the start of the click file
    daslomin-microsoft committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    28f8480 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. Configuration menu
    Copy the full SHA
    b1e3e81 View commit details
    Browse the repository at this point in the history