Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ocliff version and migrate almost all files to ts #80

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Nitix
Copy link
Contributor

@Nitix Nitix commented Mar 14, 2024

This PR migrate oclif to version 3.5.4 from version 1.x.
Migrate some files that were still in javascript.
Use ESM completely instead of commonjs.
Updated examples.
Use vitest instead of jest for better support os ESM.

One file that I didn't make it specify the context in tasks. The ListrContext is just an alias for any |undefined

Copy link

github-actions bot commented Mar 14, 2024

yarn.lock changes

Summary

Status Count
ADDED 130
UPDATED 115
DOWNGRADED 6
REMOVED 150
Click to toggle table visibility
Name Status Previous Current
@aws-sdk/chunked-blob-reader REMOVED 3.310.0 -
@aws-sdk/chunked-blob-reader-native REMOVED 3.310.0 -
@aws-sdk/client-cloudfront ADDED - 3.533.0
@aws-sdk/client-s3 UPDATED 3.369.0 3.533.0
@aws-sdk/client-sso UPDATED 3.369.0 3.533.0
@aws-sdk/client-sso-oidc UPDATED 3.369.0 3.533.0
@aws-sdk/client-sts UPDATED 3.369.0 3.533.0
@aws-sdk/core ADDED - 3.533.0
@aws-sdk/credential-provider-env UPDATED 3.369.0 3.533.0
@aws-sdk/credential-provider-http ADDED - 3.533.0
@aws-sdk/credential-provider-ini UPDATED 3.369.0 3.533.0
@aws-sdk/credential-provider-node UPDATED 3.369.0 3.533.0
@aws-sdk/credential-provider-process UPDATED 3.369.0 3.533.0
@aws-sdk/credential-provider-sso UPDATED 3.369.0 3.533.0
@aws-sdk/credential-provider-web-identity UPDATED 3.369.0 3.533.0
@aws-sdk/hash-blob-browser REMOVED 3.369.0 -
@aws-sdk/hash-stream-node REMOVED 3.369.0 -
@aws-sdk/is-array-buffer REMOVED 3.310.0 -
@aws-sdk/md5-js REMOVED 3.369.0 -
@aws-sdk/middleware-bucket-endpoint UPDATED 3.369.0 3.533.0
@aws-sdk/middleware-expect-continue UPDATED 3.369.0 3.533.0
@aws-sdk/middleware-flexible-checksums UPDATED 3.369.0 3.533.0
@aws-sdk/middleware-host-header UPDATED 3.369.0 3.533.0
@aws-sdk/middleware-location-constraint UPDATED 3.369.0 3.533.0
@aws-sdk/middleware-logger UPDATED 3.369.0 3.533.0
@aws-sdk/middleware-recursion-detection UPDATED 3.369.0 3.533.0
@aws-sdk/middleware-sdk-s3 UPDATED 3.369.0 3.533.0
@aws-sdk/middleware-sdk-sts REMOVED 3.369.0 -
@aws-sdk/middleware-signing UPDATED 3.369.0 3.533.0
@aws-sdk/middleware-ssec UPDATED 3.369.0 3.533.0
@aws-sdk/middleware-user-agent UPDATED 3.369.0 3.533.0
@aws-sdk/region-config-resolver ADDED - 3.533.0
@aws-sdk/signature-v4-multi-region UPDATED 3.369.0 3.533.0
@aws-sdk/token-providers UPDATED 3.369.0 3.533.0
@aws-sdk/types UPDATED 3.369.0 3.533.0
@aws-sdk/util-arn-parser UPDATED 3.310.0 3.495.0
@aws-sdk/util-base64 REMOVED 3.310.0 -
@aws-sdk/util-buffer-from REMOVED 3.310.0 -
@aws-sdk/util-endpoints UPDATED 3.369.0 3.533.0
@aws-sdk/util-user-agent-browser UPDATED 3.369.0 3.533.0
@aws-sdk/util-user-agent-node UPDATED 3.369.0 3.533.0
@aws-sdk/util-utf8 REMOVED 3.310.0 -
@aws-sdk/xml-builder UPDATED 3.310.0 3.533.0
@babel/helper-plugin-utils REMOVED 7.22.5 -
@babel/plugin-syntax-async-generators REMOVED 7.8.4 -
@babel/plugin-syntax-bigint REMOVED 7.8.3 -
@babel/plugin-syntax-class-properties REMOVED 7.12.13 -
@babel/plugin-syntax-import-meta REMOVED 7.10.4 -
@babel/plugin-syntax-json-strings REMOVED 7.8.3 -
@babel/plugin-syntax-logical-assignment-operators REMOVED 7.10.4 -
@babel/plugin-syntax-nullish-coalescing-operator REMOVED 7.8.3 -
@babel/plugin-syntax-numeric-separator REMOVED 7.10.4 -
@babel/plugin-syntax-object-rest-spread REMOVED 7.8.3 -
@babel/plugin-syntax-optional-catch-binding REMOVED 7.8.3 -
@babel/plugin-syntax-optional-chaining REMOVED 7.8.3 -
@babel/plugin-syntax-top-level-await REMOVED 7.14.5 -
@babel/plugin-syntax-typescript REMOVED 7.22.5 -
@bcoe/v8-coverage REMOVED 0.2.3 -
@esbuild/aix-ppc64 ADDED - 0.19.12
@esbuild/android-arm ADDED - 0.19.12
@esbuild/android-arm64 ADDED - 0.19.12
@esbuild/android-x64 ADDED - 0.19.12
@esbuild/darwin-arm64 ADDED - 0.19.12
@esbuild/darwin-x64 ADDED - 0.19.12
@esbuild/freebsd-arm64 ADDED - 0.19.12
@esbuild/freebsd-x64 ADDED - 0.19.12
@esbuild/linux-arm ADDED - 0.19.12
@esbuild/linux-arm64 ADDED - 0.19.12
@esbuild/linux-ia32 ADDED - 0.19.12
@esbuild/linux-loong64 ADDED - 0.19.12
@esbuild/linux-mips64el ADDED - 0.19.12
@esbuild/linux-ppc64 ADDED - 0.19.12
@esbuild/linux-riscv64 ADDED - 0.19.12
@esbuild/linux-s390x ADDED - 0.19.12
@esbuild/linux-x64 ADDED - 0.19.12
@esbuild/netbsd-x64 ADDED - 0.19.12
@esbuild/openbsd-x64 ADDED - 0.19.12
@esbuild/sunos-x64 ADDED - 0.19.12
@esbuild/win32-arm64 ADDED - 0.19.12
@esbuild/win32-ia32 ADDED - 0.19.12
@esbuild/win32-x64 ADDED - 0.19.12
@istanbuljs/load-nyc-config REMOVED 1.1.0 -
@istanbuljs/schema REMOVED 0.1.3 -
@jest/console REMOVED 28.1.3 -
@jest/core REMOVED 28.1.3 -
@jest/environment REMOVED 28.1.3 -
@jest/expect REMOVED 28.1.3 -
@jest/expect-utils REMOVED 28.1.3 -
@jest/fake-timers REMOVED 28.1.3 -
@jest/globals REMOVED 28.1.3 -
@jest/reporters REMOVED 28.1.3 -
@jest/schemas UPDATED 28.1.3 29.6.3
@jest/source-map REMOVED 28.1.2 -
@jest/test-result REMOVED 28.1.3 -
@jest/test-sequencer REMOVED 28.1.3 -
@jest/transform REMOVED 28.1.3 -
@jest/types REMOVED 28.1.3 -
@jridgewell/sourcemap-codec UPDATED 1.4.14 1.4.15
@oclif/color REMOVED 1.0.8 -
@oclif/core UPDATED 2.9.0 3.25.0
@oclif/linewrap REMOVED 1.0.0 -
@oclif/plugin-autocomplete ADDED - 3.0.13
@oclif/plugin-help UPDATED 5.2.12 6.0.18
@oclif/plugin-not-found UPDATED 2.3.29 3.0.14
@oclif/plugin-warn-if-update-available UPDATED 2.0.42 3.0.14
@oclif/screen REMOVED 3.0.5 -
@rollup/rollup-android-arm-eabi ADDED - 4.13.0
@rollup/rollup-android-arm64 ADDED - 4.13.0
@rollup/rollup-darwin-arm64 ADDED - 4.13.0
@rollup/rollup-darwin-x64 ADDED - 4.13.0
@rollup/rollup-linux-arm-gnueabihf ADDED - 4.13.0
@rollup/rollup-linux-arm64-gnu ADDED - 4.13.0
@rollup/rollup-linux-arm64-musl ADDED - 4.13.0
@rollup/rollup-linux-riscv64-gnu ADDED - 4.13.0
@rollup/rollup-linux-x64-gnu ADDED - 4.13.0
@rollup/rollup-linux-x64-musl ADDED - 4.13.0
@rollup/rollup-win32-arm64-msvc ADDED - 4.13.0
@rollup/rollup-win32-ia32-msvc ADDED - 4.13.0
@rollup/rollup-win32-x64-msvc ADDED - 4.13.0
@sinclair/typebox UPDATED 0.24.51 0.27.8
@sindresorhus/is ADDED - 4.6.0
@sinonjs/commons REMOVED 1.8.6 -
@sinonjs/fake-timers REMOVED 9.1.2 -
@smithy/abort-controller UPDATED 1.0.2 2.1.4
@smithy/chunked-blob-reader ADDED - 2.1.1
@smithy/chunked-blob-reader-native ADDED - 2.1.3
@smithy/config-resolver UPDATED 1.0.2 2.1.5
@smithy/core ADDED - 1.3.8
@smithy/credential-provider-imds UPDATED 1.0.2 2.2.6
@smithy/eventstream-codec UPDATED 1.0.2 2.1.4
@smithy/eventstream-serde-browser UPDATED 1.0.2 2.1.4
@smithy/eventstream-serde-config-resolver UPDATED 1.0.2 2.1.4
@smithy/eventstream-serde-node UPDATED 1.0.2 2.1.4
@smithy/eventstream-serde-universal UPDATED 1.0.2 2.1.4
@smithy/fetch-http-handler UPDATED 1.0.2 2.4.5
@smithy/hash-blob-browser ADDED - 2.1.5
@smithy/hash-node UPDATED 1.0.2 2.1.4
@smithy/hash-stream-node ADDED - 2.1.4
@smithy/invalid-dependency UPDATED 1.0.2 2.1.4
@smithy/is-array-buffer UPDATED 1.0.2 2.1.1
@smithy/md5-js ADDED - 2.1.4
@smithy/middleware-content-length UPDATED 1.0.2 2.1.4
@smithy/middleware-endpoint UPDATED 1.0.3 2.4.6
@smithy/middleware-retry UPDATED 1.0.4 2.1.7
@smithy/middleware-serde UPDATED 1.0.2 2.2.1
@smithy/middleware-stack UPDATED 1.0.2 2.1.4
@smithy/node-config-provider UPDATED 1.0.2 2.2.5
@smithy/node-http-handler UPDATED 1.0.3 2.4.3
@smithy/property-provider UPDATED 1.0.2 2.1.4
@smithy/protocol-http UPDATED 1.1.1 3.2.2
@smithy/querystring-builder UPDATED 1.0.2 2.1.4
@smithy/querystring-parser UPDATED 1.0.2 2.1.4
@smithy/service-error-classification UPDATED 1.0.3 2.1.4
@smithy/shared-ini-file-loader UPDATED 1.0.2 2.3.5
@smithy/signature-v4 UPDATED 1.0.2 2.1.4
@smithy/smithy-client UPDATED 1.0.4 2.4.5
@smithy/types UPDATED 1.1.1 2.11.0
@smithy/url-parser UPDATED 1.0.2 2.1.4
@smithy/util-base64 UPDATED 1.0.2 2.2.1
@smithy/util-body-length-browser UPDATED 1.0.2 2.1.1
@smithy/util-body-length-node UPDATED 1.0.2 2.2.2
@smithy/util-buffer-from UPDATED 1.0.2 2.1.1
@smithy/util-config-provider UPDATED 1.0.2 2.2.1
@smithy/util-defaults-mode-browser UPDATED 1.0.2 2.1.7
@smithy/util-defaults-mode-node UPDATED 1.0.2 2.2.7
@smithy/util-endpoints ADDED - 1.1.5
@smithy/util-hex-encoding UPDATED 1.0.2 2.1.1
@smithy/util-middleware UPDATED 1.0.2 2.1.4
@smithy/util-retry UPDATED 1.0.4 2.1.4
@smithy/util-stream UPDATED 1.0.2 2.1.5
@smithy/util-uri-escape UPDATED 1.0.2 2.1.1
@smithy/util-utf8 UPDATED 1.0.2 2.2.0
@smithy/util-waiter UPDATED 1.0.2 2.1.4
@szmarczak/http-timer ADDED - 4.0.6
@types/cacheable-request ADDED - 6.0.3
@types/cli-progress UPDATED 3.11.0 3.11.5
@types/estree UPDATED 1.0.1 1.0.5
@types/graceful-fs REMOVED 4.1.6 -
@types/http-cache-semantics ADDED - 4.0.4
@types/istanbul-lib-coverage REMOVED 2.0.4 -
@types/istanbul-lib-report REMOVED 3.0.0 -
@types/istanbul-reports REMOVED 3.0.1 -
@types/jest REMOVED 28.1.8 -
@types/keyv ADDED - 3.1.4
@types/responselike ADDED - 1.0.3
@types/stack-utils REMOVED 2.0.1 -
@types/yargs REMOVED 17.0.24 -
@types/yargs-parser REMOVED 21.0.0 -
@typescript-eslint/experimental-utils DOWNGRADED 5.62.0 4.33.0
@vitest/expect ADDED - 1.3.1
@vitest/runner ADDED - 1.3.1
@vitest/snapshot ADDED - 1.3.1
@vitest/spy ADDED - 1.3.1
@vitest/utils ADDED - 1.3.1
acorn UPDATED 8.10.0 8.11.3
acorn-walk UPDATED 8.2.0 8.3.2
assertion-error ADDED - 1.1.0
async-retry ADDED - 1.3.3
at-least-node REMOVED 1.0.0 -
axios UPDATED 0.25.0 1.6.7
babel-jest REMOVED 28.1.3 -
babel-plugin-istanbul REMOVED 6.1.1 -
babel-plugin-jest-hoist REMOVED 28.1.3 -
babel-preset-current-node-syntax REMOVED 1.0.1 -
babel-preset-jest REMOVED 28.1.3 -
bs-logger REMOVED 0.2.6 -
bser REMOVED 2.1.1 -
cac ADDED - 6.7.14
cacheable-lookup ADDED - 5.0.4
cacheable-request ADDED - 7.0.4
camel-case ADDED - 4.1.2
capital-case ADDED - 1.0.4
chai ADDED - 4.4.1
chalk UPDATED 4.1.2 5.3.0
change-case ADDED - 4.1.2
char-regex REMOVED 1.0.2 -
check-error ADDED - 1.0.3
cjs-module-lexer REMOVED 1.2.3 -
cli-boxes REMOVED 1.0.0 -
cliui REMOVED 8.0.1 -
clone-response ADDED - 1.0.3
co REMOVED 4.6.0 -
code-point-at REMOVED 1.1.0 -
collect-v8-coverage REMOVED 1.0.2 -
color ADDED - 4.2.3
color-string ADDED - 1.9.1
concurrently REMOVED 7.6.0 -
constant-case ADDED - 3.0.4
date-fns REMOVED 2.30.0 -
decompress-response ADDED - 6.0.0
dedent REMOVED 0.7.0 -
deep-eql ADDED - 4.1.3
deepmerge REMOVED 4.3.1 -
defer-to-connect ADDED - 2.0.1
detect-indent UPDATED 6.1.0 7.0.1
detect-newline UPDATED 3.1.0 4.0.1
diff-sequences UPDATED 28.1.1 29.6.3
dot-case ADDED - 3.0.4
emittery REMOVED 0.10.2 -
esbuild ADDED - 0.19.12
eslint-plugin-jest REMOVED 25.7.0 -
estree-walker ADDED - 3.0.3
execa UPDATED 5.1.1 8.0.1
exit REMOVED 0.1.2 -
expect REMOVED 28.1.3 -
fb-watchman REMOVED 2.0.2 -
follow-redirects UPDATED 1.15.2 1.15.5
fs-constants REMOVED 1.0.0 -
fs-extra DOWNGRADED 9.1.0 8.1.0
fsevents UPDATED 2.3.2 2.3.3
get-caller-file REMOVED 2.0.5 -
get-func-name ADDED - 2.0.2
get-stream UPDATED 6.0.1 8.0.1
git-hooks-list ADDED - 3.1.0
got ADDED - 11.8.6
has-ansi REMOVED 2.0.0 -
header-case ADDED - 2.0.4
html-escaper REMOVED 2.0.2 -
http2-wrapper ADDED - 1.0.3
human-signals UPDATED 2.1.0 5.0.0
import-local REMOVED 3.1.0 -
is-arrayish UPDATED 0.2.1 0.3.2
is-generator-fn REMOVED 2.1.0 -
is-plain-obj UPDATED 2.1.0 4.1.0
is-stream UPDATED 2.0.1 3.0.0
istanbul-lib-coverage REMOVED 3.2.0 -
istanbul-lib-instrument REMOVED 5.2.1 -
istanbul-lib-report REMOVED 3.0.0 -
istanbul-lib-source-maps REMOVED 4.0.1 -
istanbul-reports REMOVED 3.1.5 -
jest REMOVED 28.1.3 -
jest-changed-files REMOVED 28.1.3 -
jest-circus REMOVED 28.1.3 -
jest-cli REMOVED 28.1.3 -
jest-config REMOVED 28.1.3 -
jest-diff REMOVED 28.1.3 -
jest-docblock REMOVED 28.1.1 -
jest-each REMOVED 28.1.3 -
jest-environment-node REMOVED 28.1.3 -
jest-get-type REMOVED 28.0.2 -
jest-haste-map REMOVED 28.1.3 -
jest-leak-detector REMOVED 28.1.3 -
jest-matcher-utils REMOVED 28.1.3 -
jest-message-util REMOVED 28.1.3 -
jest-mock REMOVED 28.1.3 -
jest-pnp-resolver REMOVED 1.2.3 -
jest-regex-util REMOVED 28.0.2 -
jest-resolve REMOVED 28.1.3 -
jest-resolve-dependencies REMOVED 28.1.3 -
jest-runner REMOVED 28.1.3 -
jest-runtime REMOVED 28.1.3 -
jest-snapshot REMOVED 28.1.3 -
jest-util REMOVED 28.1.3 -
jest-validate REMOVED 28.1.3 -
jest-watcher REMOVED 28.1.3 -
jest-worker REMOVED 28.1.3 -
js-tokens UPDATED 4.0.0 8.0.3
json-buffer ADDED - 3.0.1
jsonc-parser ADDED - 3.2.1
jsonfile DOWNGRADED 6.1.0 4.0.0
keyv ADDED - 4.5.4
kleur REMOVED 3.0.3 -
leven REMOVED 3.1.0 -
load-json-file REMOVED 6.2.0 -
local-pkg ADDED - 0.5.0
lodash._reinterpolate ADDED - 3.0.0
lodash.memoize REMOVED 4.1.2 -
lodash.template ADDED - 4.5.0
lodash.templatesettings ADDED - 4.2.0
loupe ADDED - 2.3.7
lower-case ADDED - 2.0.2
lowercase-keys UPDATED 1.0.1 2.0.0
magic-string ADDED - 0.30.8
makeerror REMOVED 1.0.12 -
mimic-fn UPDATED 2.1.0 4.0.0
mimic-response ADDED - 3.1.0
mkdirp-classic REMOVED 0.5.3 -
mlly ADDED - 1.6.1
nanoid ADDED - 3.3.7
nice-try REMOVED 1.0.5 -
no-case ADDED - 3.0.4
node-int64 REMOVED 0.4.0 -
normalize-url ADDED - 6.1.0
npm-run-path UPDATED 4.0.1 5.3.0
number-is-nan REMOVED 1.0.1 -
oclif UPDATED 2.7.0 4.5.4
onetime UPDATED 5.1.2 6.0.0
p-cancelable ADDED - 2.1.1
p-limit UPDATED 4.0.0 5.0.0
pad-component REMOVED 0.0.1 -
param-case ADDED - 3.0.4
pascal-case ADDED - 3.1.2
password-prompt UPDATED 1.1.2 1.1.3
path-case ADDED - 3.0.4
path-key UPDATED 3.1.1 4.0.0
pathe ADDED - 1.1.2
pathval ADDED - 1.1.1
pirates REMOVED 4.0.6 -
pkg-types ADDED - 1.0.3
postcss ADDED - 8.4.35
pretty-format UPDATED 28.1.3 29.7.0
prompts REMOVED 2.4.2 -
qqjs REMOVED 0.3.11 -
require-directory REMOVED 2.1.1 -
resolve-alpn ADDED - 1.2.1
resolve-cwd REMOVED 3.0.0 -
resolve.exports REMOVED 1.1.1 -
responselike ADDED - 2.0.1
retry UPDATED 0.12.0 0.13.1
rollup ADDED - 4.13.0
semver UPDATED 7.5.4 7.6.0
sentence-case ADDED - 3.0.4
shell-quote REMOVED 1.8.1 -
siginfo ADDED - 2.0.0
signal-exit UPDATED 4.0.2 4.1.0
simple-swizzle ADDED - 0.2.2
sisteransi REMOVED 1.0.5 -
snake-case ADDED - 3.0.4
sort-object-keys ADDED - 1.1.3
sort-package-json ADDED - 2.8.0
source-map-js ADDED - 1.0.2
source-map-support UPDATED 0.5.13 0.5.21
spawn-command REMOVED 0.0.2-1 -
stack-utils REMOVED 2.0.6 -
stackback ADDED - 0.0.2
std-env ADDED - 3.7.0
string-length REMOVED 4.0.2 -
strip-bom DOWNGRADED 4.0.0 3.0.0
strip-eof REMOVED 1.0.0 -
strip-final-newline UPDATED 2.0.0 3.0.0
strip-literal ADDED - 2.0.0
taketalk REMOVED 1.0.0 -
tar-fs REMOVED 2.1.1 -
tar-stream REMOVED 2.2.0 -
terminal-link REMOVED 2.1.1 -
test-exclude REMOVED 6.0.0 -
tinybench ADDED - 2.6.0
tinypool ADDED - 0.8.2
tinyspy ADDED - 2.2.1
tmpl REMOVED 1.0.5 -
ts-jest REMOVED 28.0.8 -
ts-node UPDATED 10.9.1 10.9.2
tslib UPDATED 2.6.0 2.6.2
typedarray-to-buffer REMOVED 3.1.5 -
typescript UPDATED 4.9.5 5.4.2
ufo ADDED - 1.4.0
universalify DOWNGRADED 2.0.0 0.1.2
upper-case ADDED - 2.0.2
upper-case-first ADDED - 2.0.2
v8-to-istanbul REMOVED 9.1.0 -
vite ADDED - 5.1.6
vite-node ADDED - 1.3.1
vitest ADDED - 1.3.1
walker REMOVED 1.0.8 -
why-is-node-running ADDED - 2.2.2
write-json-file REMOVED 4.3.0 -
y18n REMOVED 5.0.8 -
yargs REMOVED 17.7.2 -
yargs-parser DOWNGRADED 21.1.1 20.2.9
yeoman-generator UPDATED 5.9.0 5.10.0
yosay REMOVED 2.0.2 -

Copy link

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed ~60% of the files. Not sure if I'll have time to review the rest though 😅

"prettier": "^2.4.1",
"trace-unhandled": "^2.0.1",
"ts-jest": "^28.0.7",
"ts-node": "^10.9.2",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a main dep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was the case, but it's only needed on dev. Creating a new project with oclif put it in dev dependencies.
Furthermore, typescript is compiled of release

@@ -0,0 +1 @@
# examples
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file necessary?

Comment on lines +40 to +43
auth: {
username: kc.getCurrentUser()?.username ?? '',
password: kc.getCurrentUser()?.password ?? '',
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure it's fully equivalent... how about servername?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not present in axios options.
Kube command only add username, password and servername. Types are not compatible between the two.

Comment on lines +3 to +13
vi.mock('../utils.js', async (importOriginal) => {
const actual = await importOriginal<typeof import('../utils.js')>();
return {
...actual,
getCommitMessage: vi.fn(),
getBranchName: vi.fn(),
getCommitId: vi.fn(),
getCommitAncestorWithDefaultBranch: vi.fn(),
getDirectCommitAncestor: vi.fn(),
};
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: not found of setting the mock inbetween import statements

Comment on lines +3 to +9
vi.mock('node:child_process', async (importOriginal) => {
const actual = await importOriginal<typeof import('node:child_process')>();
return {
...actual,
exec: vi.fn(),
};
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants