Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Pause Updates" to Use ICU #3167

Closed
wants to merge 4 commits into from

Conversation

mrixner
Copy link
Contributor

@mrixner mrixner commented Jan 7, 2025

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

I tried to make the format string automatically handle the stuff, but it doesn't seem like it supports any plural matching aside from specific numbers. Feel free to revert / change anything you prefer the other / a different version of, as always.

@marticliment
Copy link
Owner

I have looked at this, and, to be honest, I reckon it will be more confusing (both for me and for the translators) to have to translate this long strings than to use the already existing strings differentiating one and many.

Furthermore, most of this strings are already translated (since they are already used on the settings page), so I am going to close this pr.

Nevertheless, thanks for putting the effort into it.

@mrixner mrixner deleted the pause-updates branch January 17, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants