✨ Add latex formatter (for songs package) #107
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
ftes
force-pushed
the
feature/latex-formatter
branch
from
95dc6e5
to
dc81920
Compare
ftes
force-pushed
the
feature/latex-formatter
branch
2 times, most recently
from
f105c4f
to
d722f7d
Compare
ftes
force-pushed
the
feature/latex-formatter
branch
from
d722f7d
to
c26a156
Compare
ftes
force-pushed
the
feature/latex-formatter
branch
3 times, most recently
from
17c3ac8
to
980df5f
Compare
|
Hey @ftes, sorry to reply this late. Your PR looks nice! Just out of curiosity, do you have an example how this would be rendered by LaTex? There are two issues preventing this from being mergeble: Code Climate is complaining and the branch got out-of-date. Could you perhaps try to rebase the branch? Then I will try to find out what Code Climate is complaining about (it keeps saying it doesn't have an analysis 🤔) |
|
Here's an example of what it might look like.
You cannot use the output standalone though, but have to embed it in a proper Latex wrapper document which also has `\usepackage[chorded]{songs}. |
- Only supports a very limited subset of tags so far (artist, title, subtitle, comment, capo) - Other tags are simply rendered as `\textcomment` - The result has additional newlines, because some tags are filtered out to construct the first `\beginsong` line. If they were the sole item on their previous line, that line remains as an empty line.
ftes
force-pushed
the
feature/latex-formatter
branch
from
980df5f
to
95301aa
Compare
|
Code Climate has analyzed commit 95301aa and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Code duplication found. Personally I would keep it duplicated rather than extracting 4 lines of code. I can't see how to mark this as |
|
@ftes Should we try and rebase this PR? CodeClimate does not have the PR analysis available... |
|
Hey @ftes. Would you like to get your branch merged? If not, I'll plan to use your implementation on a fresh branch (and credit you of course 😉 ) |
|
Please feel free to use it any way you please. Unfortunately I do not have
any time to spare at the moment. Thanks for asking!
…On Sun, Oct 11, 2020, 09:50 Martijn Versluis ***@***.***> wrote:
Hey @ftes <https://github.com/ftes>. Would you like to get your branch
merged? If not, I'll plan to use your implementation on a fresh branch (and
credit you of course 😉 )
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#107 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAT6LTA3XSYSF7TD23JT3R3SKFPS3ANCNFSM4ITKETBQ>
.
|
| formatTag(tag) { | ||
| switch (tag.name) { | ||
| case COMMENT: | ||
| return `\\textcomment{${tag.value}}`; |
There was a problem hiding this comment.
This should be \\textnote{${tag.value}}; per the docs. \textcomment gives an error for me. However, the songs package does not support Intros, outros, breaks etc. A ''workaround'' for this is to use the \nolyrics option. For example:
\beginverse
{\nolyrics Outro:
\[G] \[D] \[A] \[F\#m] \[Em] \[D] \[A] \[Em]}
\endverse
There was a problem hiding this comment.
Not sure how to implement that though...
\textcomment\beginsongline. If they were the sole item on their previous line, that line remains as an empty line.