Allows :dql_parameters with ARRAY_* functions #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
compare to the other PR I've added additional test and used ArithmeticPrimary that allow both Literal and input parameters , as well as other methods returning string (which allow chaining calls ) |
allan-simon
commented
Oct 16, 2024
tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayAppendTest.php
Outdated
Show resolved
Hide resolved
before it was only possible to do `ARRAY_APPEND(e.myarray, 'a_literal')` so it was impossible to have the value coming from php (without resorting to DQL injection) We now allow also the following syntax `ARRAY_APPEND(e.myarray, :foobar)`
allan-simon
force-pushed
the
allow_input_parameters_with_array_functions
branch
from
80436f4 to
12d7f5c
Compare
|
I think only CI failure remains to be addressed. Thank you 😊 |
allan-simon
commented
Oct 21, 2024
tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayAppendTest.php
Outdated
Show resolved
Hide resolved
tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayAppendTest.php
Outdated
Show resolved
Hide resolved
tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayPrependTest.php
Outdated
Show resolved
Hide resolved
tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayPrependTest.php
Outdated
Show resolved
Hide resolved
tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayRemoveTest.php
Outdated
Show resolved
Hide resolved
tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayRemoveTest.php
Outdated
Show resolved
Hide resolved
tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayReplaceTest.php
Show resolved
Hide resolved
tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayReplaceTest.php
Show resolved
Hide resolved
coding style
|
@martin-georgiev it was some coding style issue, should be good now :) |
martin-georgiev
previously approved these changes
Oct 21, 2024
allan-simon
commented
Oct 21, 2024
tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayReplaceTest.php
Outdated
Show resolved
Hide resolved
allan-simon
commented
Oct 21, 2024
tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayReplaceTest.php
Outdated
Show resolved
Hide resolved
|
@martin-georgiev sorry, i was a bit fast in the correction of the coding style, it's ok now, the scrutinizer error is a timeout so i think it's just need a relaunch ? |
martin-georgiev
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before it was only possible to do
ARRAY_APPEND(e.myarray, 'a_literal')so it was impossible to have the value coming from php (without resorting to DQL injection)We now allow also the following syntax
ARRAY_APPEND(e.myarray, :foobar)