mockobject: Allow adding objects derived from DBusMockObject #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to use this in the mutter test suite: https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4022/diffs |
martinpitt
requested changes
Oct 3, 2024
swick
force-pushed
the
wip/derivable-dbus-mock-objects
branch
from
bbcb469
to
13fa944
Compare
|
Tried to add documentation and a unit test. Let me know if it needs adjusting. |
|
@swick thanks! I'm AFK until next Wednesday, will re-review then. But at a quick glance this looks great! |
|
There's some pylint/ruff/black failures, see test failure. If you don't feel like fixing these (installing these tools and running the tests), I'm happy to do that, too. |
swick
force-pushed
the
wip/derivable-dbus-mock-objects
branch
from
13fa944
to
dc6a386
Compare
|
I think I managed to fix it. If something is still wrong, feel free to take over. |
We are going to add an 8th argument to the DBusMockObject constructor.
This allows to create objects instanciated from a DBusMockObject subclass in mock templates. That way, implementing dynamic objects becomes easier by using dbus decorators. This also allows passing some extra data to the DBusMockObject derived class constructor so it becomes possible to store some data in the object created via DBusMockObject.add_object which can be useful if one e.g. needs some information stored in the parent object.
martinpitt
force-pushed
the
wip/derivable-dbus-mock-objects
branch
from
dc6a386
to
247d50b
Compare
|
Thanks @swick ! I rebased, fixed a trivial black error, and some docstring formatting. |
martinpitt
approved these changes
Oct 9, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to create objects instanciated from a DBusMockObject subclass in mock templates. That way, implementing dynamic objects becomes easier by using dbus decorators: