fix: logging behavior #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace loguru with standard Python logging - Make logging configurable and opt-in by default - Fix log levels for validation results - Improve code organization and type hints - Add data extraction helper method - Clean up validation logic
5u6r054
requested review from
theMultitude and
grantdfoster
and removed request for
theMultitude
- Add explicit handling for ServerDisconnectedError\n- Log disconnection errors at debug level only\n- Prevent error propagation to parent application logs\n- Maintain consistent retry behavior with other network errors
- Remove ServerDisconnectedError import as it's not available in all requests versions\n- Handle server disconnections using the more general ConnectionError\n- Update error message to indicate possible server disconnection\n- Maintain same retry behavior for all connection issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Package Logging Behavior
This PR improves the logging behavior of the package, particularly for the tweet validation functionality. The changes make the package more respectful of the parent application's logging preferences and add better error handling.
Key Changes
Logging Improvements
Error Handling
Code Quality
Example Log Output
Before:
After:
Testing
The changes have been tested with:
Production Testing
These changes have been successfully tested in production on the Subnet 42 validator, handling high-volume tweet validation with improved rate limiting and cleaner logging output. The validator maintained stable operation with the new logging behavior while processing multiple concurrent validation requests.
Breaking Changes
None. The public API remains unchanged, only the logging behavior has been modified to be less intrusive.