-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻ refactor(IDistributedCache): Optimize connections under Isolation and Attempt to reconnect #740
Draft
wzh425
wants to merge
4
commits into
main
Choose a base branch
from
feature/distributed-cache
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
21 changes: 21 additions & 0 deletions
21
...uildingBlocks/Caching/Masa.BuildingBlocks.Caching/Internal/DistributedCacheClientCache.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// Copyright (c) MASA Stack All rights reserved. | ||
// Licensed under the MIT License. See LICENSE.txt in the project root for license information. | ||
|
||
namespace Masa.BuildingBlocks.Caching; | ||
|
||
internal class DistributedCacheClientCache | ||
{ | ||
public static ConcurrentDictionary<string, IManualDistributedCacheClient> CacheClients { get; set; } = new(); | ||
|
||
public IManualDistributedCacheClient GetCacheClient(IServiceProvider serviceProvider) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IHttpClientFactory用的时CreateClient,要对其它吗? |
||
{ | ||
var multiEnvironmentContext = serviceProvider.GetRequiredService<IMultiEnvironmentContext>(); | ||
var environment = multiEnvironmentContext.CurrentEnvironment; | ||
|
||
return CacheClients.GetOrAdd(environment, env => | ||
{ | ||
var cacheClient = serviceProvider.GetRequiredService<ScopedService<IManualDistributedCacheClient>>().Service; | ||
return cacheClient; | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,29 +7,29 @@ public abstract class RedisCacheClientBase : DistributedCacheClientBase | |
{ | ||
protected readonly string? InstanceId; | ||
protected static readonly Guid UniquelyIdentifies = Guid.NewGuid(); | ||
protected readonly ISubscriber Subscriber; | ||
protected ISubscriber Subscriber; | ||
|
||
protected IDatabase Db | ||
{ | ||
get | ||
{ | ||
if (_connection.IsConnected || _connection.IsConnecting) | ||
return _connection.GetDatabase(); | ||
|
||
throw new NotSupportedException("Redis service has been disconnected, please wait for reconnection and try again"); | ||
return EnsureDbConnection(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. EnsureABC方法一般是返回void,里面可以抛异常。大概是这样: EnsureABC();
return _connect.GetDatabase(); |
||
} | ||
} | ||
|
||
private readonly IConnectionMultiplexer _connection; | ||
private IConnectionMultiplexer _connection; | ||
protected readonly JsonSerializerOptions GlobalJsonSerializerOptions; | ||
private readonly CacheEntryOptions _globalCacheEntryOptions; | ||
private readonly CacheOptions _globalCacheOptions; | ||
|
||
private readonly RedisConfigurationOptions _redisConfigurationOptions; | ||
|
||
protected RedisCacheClientBase( | ||
RedisConfigurationOptions redisConfigurationOptions, | ||
JsonSerializerOptions? jsonSerializerOptions) | ||
: this(redisConfigurationOptions.GlobalCacheOptions, redisConfigurationOptions, jsonSerializerOptions) | ||
{ | ||
_redisConfigurationOptions = redisConfigurationOptions; | ||
var redisConfiguration = redisConfigurationOptions.GetAvailableRedisOptions(); | ||
_connection = ConnectionMultiplexer.Connect(redisConfiguration); | ||
Subscriber = _connection.GetSubscriber(); | ||
|
@@ -51,6 +51,28 @@ private RedisCacheClientBase( | |
GlobalJsonSerializerOptions = jsonSerializerOptions ?? new JsonSerializerOptions().EnableDynamicTypes(); | ||
} | ||
|
||
protected IDatabase EnsureDbConnection() | ||
{ | ||
if (_connection.IsConnected || _connection.IsConnecting) | ||
{ | ||
return _connection.GetDatabase(); | ||
} | ||
|
||
// Attempt to reconnect | ||
var redisConfiguration = _redisConfigurationOptions.GetAvailableRedisOptions(); | ||
_connection = ConnectionMultiplexer.Connect(redisConfiguration); | ||
Subscriber = _connection.GetSubscriber(); | ||
|
||
if (_connection.IsConnected || _connection.IsConnecting) | ||
{ | ||
return _connection.GetDatabase(); | ||
} | ||
else | ||
{ | ||
throw new NotSupportedException("Unable to reconnect to Redis, please check the connection settings and try again."); | ||
} | ||
} | ||
|
||
protected T? ConvertToValue<T>(RedisValue value, out bool isExist) | ||
{ | ||
if (value is { HasValue: true, IsNullOrEmpty: false }) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DistributedCacheClientCache的后缀Cache是OK的吗?你这是个工厂吧,改成ClientFactory?