forked from codeforamerica/citygram
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
working on codeforamerica#203, notify endpoint publisher when failed …
…sidekiq worker.
- Loading branch information
1 parent
7e592dc
commit 5045a26
Showing
1 changed file
with
34 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5045a26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This attempt is 🔥 🔥 🔥
Unfortunately, though, we need something to back off sending it every ten minutes. 🚒 We would have sent the historic district one tens of thousands of times. Do you see a way to do (say) once a day?
5045a26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And tests wouldn't hurt! I do want to depend on this.
5045a26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly, a work in progress and test would certainly be appropriate. 😄
Figuring that once sidekiq retries is dead and can no longer attempt, then at that point the publisher endpoint contact would be emailed. At least this was my understanding according to sidekiq documentation, https://github.com/mperham/sidekiq/wiki/Error-Handling. There is the question of where or who is responsible for maintaining the publisher endpoint contact (ie. email).
@bigfleet, what are your thoughts on this and introducing an error / log monitoring service or even help desk / 3rd party monitoring / paging integration? I am figuring that we may want to be cost conscientious.