Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support standard webpush #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

p1gp1g
Copy link

@p1gp1g p1gp1g commented Jan 16, 2025

Mastodon now support standard webpush: mastodon/mastodon#33528, it will be in mastodon 4.4.0. If we want to migrate clients using FCM we need to support the standard push here too

The content in the p field is enough to decrypt the push notification, rfc is added to know it comes from a standard push notification. Another solution is to simply not set k and s, so if they aren't there, we know it is a standard push. But I think it is better to add a field for that

Copy link

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not convinced adding a rfc field is useful, but it probably doesn't hurt much either.

@p1gp1g
Copy link
Author

p1gp1g commented Jan 21, 2025

By the way, you don't need a gateway for webpush to FCM when using the standard webpush. You can directly send the messages to FCM (google) servers: https://gist.github.com/mar-v-in/2a054e3a4c0a508656549fc7d0aaeb74#webpush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants