Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeView control for Landmarks #238

Open
matatk opened this issue Jan 5, 2019 · 0 comments
Open

TreeView control for Landmarks #238

matatk opened this issue Jan 5, 2019 · 0 comments
Assignees

Comments

@matatk
Copy link
Owner

matatk commented Jan 5, 2019

This will lay the foundation for providing headings in future. It will also mean that the tree has one tab stop and thus makes it possible to include help and options links in the pop-up directly.

It will allow all those UI changes; it also seems like a good opportunity to start moving to considering the landmark regions (and other things) found by the content script as a tree structure rather than a list. Landmarks can be inside other landmarks, and headings can be inside landmarks too.

To ensure that the results are correct, the tree should be flattened into a list during development, so that the code can be changed without changing the tests, then the tests can be updated once the code is known to be working.

@matatk matatk added this to the 2.6.0 milestone Jan 5, 2019
@matatk matatk self-assigned this Jan 5, 2019
@matatk matatk removed this from the 2.x milestone Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant