Solution #2322
Open
Solution #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvjl000
suggested changes
Nov 13, 2023
src/makeRobotAccountant.js
Outdated
| const error = 'Bzzz... Error!'; | ||
|
|
||
| return (a) => { | ||
| count++; |
There was a problem hiding this comment.
I wonder whether we should increment count in this place. Right now, the count will be incremented even if we don't invoke the last returned function.
I would put it in the last function, but it is not specified in the task description so I leave the decision to you. I just wanted to make sure that you are aware of this closure behavior.
src/makeRobotAccountant.js
Outdated
| return error; | ||
| } | ||
|
|
||
| const sum = a + b; |
There was a problem hiding this comment.
Since we are using this value only once, there is no need to create a variable for it. Simply return the calculation
src/makeRobotAccountant.js
Outdated
| @@ -6,7 +6,22 @@ | |||
| */ | |||
|
|
|||
| function makeRobotAccountant() { | |||
| // write code here | |||
| let count = 0; | |||
| const error = 'Bzzz... Error!'; | |||
mbruhler
suggested changes
Nov 14, 2023
src/makeRobotAccountant.js
Outdated
| return (b) => { | ||
| count++; | ||
|
|
||
| if (count > 3 & count % 2 === 0) { |
There was a problem hiding this comment.
This is not a logical operator here (&), you should use the proper one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.