All tests are completed #2378
Open
All tests are completed #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Jun 3, 2024
Comment on lines
+11
to
+23
| function getSum(number) { | ||
| return function(value) { | ||
| count++; | ||
|
|
||
| const result = value + number; | ||
|
|
||
| if (count % 2 === 0 && count > 3) { | ||
| return 'Bzzz... Error!'; | ||
| } else { | ||
| return result; | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
The inner function returned by getSum should not be named. You can simply return an anonymous function.
|
|
||
| const result = value + number; | ||
|
|
||
| if (count % 2 === 0 && count > 3) { |
There was a problem hiding this comment.
You should use one variable for counting function calls. Here, you are using count correctly to keep track of the calls to the returned function.
|
|
||
| const result = value + number; | ||
|
|
||
| if (count % 2 === 0 && count > 3) { |
There was a problem hiding this comment.
Consider combining the conditions in the if statement to avoid nesting ternary operators or multiple if-else statements. Since you're only checking one condition, it's not necessary to use an else statement; you can return result directly after the if block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.