Solution #2383
Solution #2383
Conversation
There was a problem hiding this comment.
Great job on the Pull Request! 🌟 While there are some minor code style suggestions, such as simplifying conditional logic and using anonymous functions, these don't significantly impact the functionality or security of your code. Keep these tips in mind for cleaner and more efficient code in your future work! Happy coding! 😊👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/makeRobotAccountant.js
Outdated
| function makeRobotAccountant() { | ||
| // write code here | ||
| let count = 0; | ||
|
|
||
| return function(a) { | ||
| return function(b) { | ||
| count++; | ||
|
|
||
| if (count <= 3 || count % 2 !== 0) { | ||
| const sum = a + b; | ||
|
|
||
| return sum; | ||
| } else { | ||
| return 'Bzzz... Error!'; | ||
| } | ||
| }; | ||
| }; |
There was a problem hiding this comment.
[CODE STYLE] - You don't need to name functions if you return them right away. Consider using anonymous functions instead.
src/makeRobotAccountant.js
Outdated
| if (count <= 3 || count % 2 !== 0) { | ||
| const sum = a + b; | ||
|
|
||
| return sum; | ||
| } else { | ||
| return 'Bzzz... Error!'; | ||
| } |
There was a problem hiding this comment.
[CODE STYLE] - DRY. When you do similar logic, try to combine conditions. Here, you can simplify the conditional logic by checking for count > 3 and count % 2 === 0 as a single case to return 'Bzzz... Error!' and return the sum in all other cases.
No description provided.