Develop #2388
Develop #2388
Conversation
There was a problem hiding this comment.
Great job on the implementation! 👍 Just a few code style suggestions to keep in mind for the future: try to keep your code DRY by combining conditions when possible, avoid nesting ternary operators for better readability, and consider using anonymous functions when naming isn't necessary. These changes can help make your code even cleaner and easier to maintain! Keep up the good work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| return a + b; | ||
| } | ||
| }; | ||
| }; |
There was a problem hiding this comment.
[CODE STYLE] - You don't need to name functions if you return them right away. Consider using anonymous functions instead to make the code cleaner. For example, return function (b) { ... };
src/makeRobotAccountant.js
Outdated
| if (callCount > 3 && callCount % 2 === 0) { | ||
| return "Bzzz... Error!"; | ||
| } else { | ||
| return a + b; | ||
| } |
There was a problem hiding this comment.
[CODE STYLE] - Try not to nest ternary operators. Instead, you can use a single conditional statement or separate the logic into multiple statements to improve readability.
src/makeRobotAccountant.js
Outdated
| if (callCount > 3 && callCount % 2 === 0) { | ||
| return "Bzzz... Error!"; | ||
| } else { | ||
| return a + b; |
There was a problem hiding this comment.
[CODE STYLE] - DRY. You can combine conditions to simplify the logic. For instance, you can check if callCount is less than or equal to 3 to return the sum directly, reducing the need for an else block.
No description provided.