Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #4827

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #4827

wants to merge 2 commits into from

Conversation

AsyaDev14
Copy link

No description provided.

Copy link

@Fridrif27 Fridrif27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix your code

src/calculateRentalCost.js Outdated Show resolved Hide resolved
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's a critical issue with the discount logic in your calculateRentalCost function. The current implementation applies fixed discounts for rentals longer than 3 and 7 days, but it might not align with the task requirements if cumulative discounts are needed. Please review the task description and adjust the logic to ensure it meets the specified discount structure. Once this is addressed, your code will be in great shape! Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/calculateRentalCost.js Outdated Show resolved Hide resolved
Copy link

@Fridrif27 Fridrif27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

Copy link

@polosanya polosanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pay attention to the checklist

src/calculateRentalCost.js Outdated Show resolved Hide resolved
src/calculateRentalCost.js Outdated Show resolved Hide resolved
Copy link

@polosanya polosanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment above

Copy link

@BudnikOleksii BudnikOleksii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants