Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #4834

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #4834

wants to merge 2 commits into from

Conversation

pogorielova
Copy link

No description provided.

Eeoneishin
Eeoneishin approved these changes Oct 28, 2024
View reviewed changes
Copy link

@Eeoneishin Eeoneishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, approve

VolodymyrKirichenko
VolodymyrKirichenko approved these changes Oct 29, 2024
View reviewed changes
Copy link

@VolodymyrKirichenko VolodymyrKirichenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🔥
But check my comment and fix it.

src/calculateRentalCost.js Outdated
Comment on lines 7 to 11
const RENTAL_COST = 40;
const SHORT_DISCOUNT_PERIOD = 3;
const LONG_DISCOUNT_PERIOD = 7;
const SHORT_DISCOUNT = 20;
const LONG_DISCOUNT = 50;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move CONSTANTS outside the function.
CONSTANT - This is a variable that is created only 1 time and never changes.
In ur case, it is created every time the function is called

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eeoneishin Eeoneishin Eeoneishin approved these changes

@VolodymyrKirichenko VolodymyrKirichenko VolodymyrKirichenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pogorielova @VolodymyrKirichenko @Eeoneishin