calculate rental amount #4853
calculate rental amount #4853
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this task! 😊 While your solution is on the right track, there's a critical issue with the discount logic that needs to be addressed. Currently, both discounts can be applied simultaneously, which is not the intended behavior. You should adjust the logic to ensure only the highest applicable discount is applied. Additionally, consider replacing hardcoded literals with constants for better readability and maintainability, and use const instead of let where possible. Once these changes are made, your code will be much stronger! Keep up the great work! 💪
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/calculateRentalCost.js
Outdated
| if (days >= 3) { | ||
| return totalSum - 20; |
There was a problem hiding this comment.
Logical issue: The current logic applies a $20 discount for rentals of 3 or more days, even if a $50 discount for 7 or more days has already been applied. Consider using an else if statement here to ensure only one discount is applied.
src/calculateRentalCost.js
Outdated
| for (let day = 1; day <= days; day++) { | ||
| totalSum = totalSum + pricePerDay; | ||
| } |
There was a problem hiding this comment.
i think you can use multiplying for this)
src/calculateRentalCost.js
Outdated
| } | ||
|
|
||
| if (days >= 7) { | ||
| return totalSum - 50; |
There was a problem hiding this comment.
looks like magic number, create variable for all discount
No description provided.