Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1295

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #1295

wants to merge 3 commits into from

Conversation

Waldemar-wal
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on this task! 😊 While your solution is mostly on point, there are a couple of critical issues that need to be addressed to fully meet the task requirements:

  1. Class Initialization:

    • The Cat and Dog classes should not allow the appetite to be set during initialization. The Cat should have a default appetite of 3, and the Dog should have a default appetite of 7, without parameters to change these values during initialization.
  2. Use of Generator Expression:

    • In the feed_animals function, replace the for loop with a generator expression to sum the food points, as this is a more efficient and concise approach.

These changes are necessary to ensure your code aligns with the task's core requirements. Once you address these points, your solution will be ready for approval. Keep up the great work, and don't hesitate to reach out if you have any questions! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

app/main.py Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
@Waldemar-wal Waldemar-wal reopened this Oct 28, 2024
@Waldemar-wal Waldemar-wal marked this pull request as draft October 29, 2024 09:12
@Waldemar-wal Waldemar-wal marked this pull request as ready for review October 30, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants