Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 44 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,44 @@
# write your code here
class Animal:
def __init__(self, name: str,
appetite: int,
is_hungry: bool = True) -> None:
self.name = name
self.appetite = appetite
self.is_hungry = is_hungry

def print_name(self) -> str:
print(f"Hello, I\'m {self.name}")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method print_name is defined to return a str, but it actually returns None because it only prints the name. Consider changing the return type to None or returning a string.


def feed(self) -> str | int:
if self.is_hungry:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method feed is defined to return str | int, but it only returns an int. Consider updating the return type to int unless you plan to return a string in some cases.

print(f"Eating {self.appetite} food points...")
self.is_hungry = False
return self.appetite
else:
return 0


class Cat(Animal):
def __init__(self, name: str, is_hungry: bool = True) -> None:
super().__init__(name, appetite=3, is_hungry=is_hungry)

def catch_mouse(self) -> str:
print("The hunt began!")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method catch_mouse is defined to return a str, but it actually returns None because it only prints a message. Consider changing the return type to None or returning a string.



class Dog(Animal):
def __init__(self, name: str, is_hungry: bool = True) -> None:
super().__init__(name, appetite=7, is_hungry=is_hungry)

def bring_slippers(self) -> str:
print("The slippers delivered!")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method bring_slippers is defined to return a str, but it actually returns None because it only prints a message. Consider changing the return type to None or returning a string.



def feed_animals(list_of_animals: list[Animal]) -> int:
food = 0
for animal in list_of_animals:
if animal.is_hungry:
animal.feed()
food += animal.appetite
print(food)
return food
Loading