Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1311

wants to merge 1 commit into from

Conversation

bashyrov
Copy link

@bashyrov bashyrov commented Nov 6, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the class hierarchy for animals! 🐾 Your code meets the task requirements and constraints effectively. While there are a couple of minor issues, such as the type hint for the animals parameter and an extra space in self.name, these don't significantly impact the functionality. Keep up the good work, and consider these small improvements for even cleaner code in the future! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


def __init__(self, name: str,
appetite: int, is_hungry: bool = True) -> None:
self. name = name

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space after self. in self. name. This will cause a syntax error. It should be self.name without the space.

print("The slippers delivered!")


def feed_animals(animals: list) -> int:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type hint for the animals parameter in feed_animals should specify that it is a list of Animal objects, e.g., list[Animal], to improve type safety and clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants