solution py-feed-animals #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olena-hul
suggested changes
Aug 18, 2023
app/main.py
Outdated
Comment on lines
2
to
4
| def __init__(self, name: str, | ||
| appetite: int, | ||
| is_hungry: bool = True) -> None: |
There was a problem hiding this comment.
Place each argument in a separate line
Bohdan-Salamakha
suggested changes
Aug 18, 2023
app/main.py
Outdated
Comment on lines
46
to
48
| total_food_points = sum(animal.feed() | ||
| for animal in animals if animal.is_hungry) | ||
| return total_food_points |
There was a problem hiding this comment.
simplify it
Suggested change
| total_food_points = sum(animal.feed() | |
| for animal in animals if animal.is_hungry) | |
| return total_food_points | |
| return sum( | |
| animal.feed() for animal in animals if animal.is_hungry | |
| ) |
Bohdan-Salamakha
suggested changes
Aug 19, 2023
app/main.py
Outdated
| print("The slippers delivered!") | ||
|
|
||
|
|
||
| def feed_animals(animals: list) -> int: |
There was a problem hiding this comment.
add additional typehint for list inner objects like list[YOUR_VALUE_TYPE]
for example: list that contains string elements has typehint list[str]
Bohdan-Salamakha
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.